Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide_border not working #2280

Closed
jgphilpott opened this issue Nov 21, 2022 · 2 comments
Closed

hide_border not working #2280

jgphilpott opened this issue Nov 21, 2022 · 2 comments
Labels
bug Something isn't working.

Comments

@jgphilpott
Copy link

Describe the bug

I have been using these cards for over a year with hide_border=true but today the borders showed up on my profile. Something in a recent PR must have broken this functionality.

Expected behaviour

No border visible when hide_border=true is used.

Screenshots / Live demo link

Take a look at my profile.

Additional context

Only started today.

@jgphilpott jgphilpott added the bug Something isn't working. label Nov 21, 2022
@rickstaa
Copy link
Collaborator

@jgphilpott, thanks for your bug report. I think the changes I made in #2029 messed up your card. This might be because of a syntax error in your card syntax and a fix I performed for incorrect boolean fallback values (see #2026). You seem to use hide_border=ture instead of hide_border=trueon your profile which now correctly falls back to the default value of false. For me, the hide_border argument is working correctly.

With hide border

Anurag's GitHub stats

[![Anurag's GitHub stats](https://github-readme-stats.vercel.app/api?username=anuraghazra&hide_border=true)](https://github.com/anuraghazra/github-readme-stats)

Without hide border

Anurag's GitHub stats
Anurag's GitHub stats

[![Anurag's GitHub stats](https://github-readme-stats.vercel.app/api?username=anuraghazra)](https://github.com/anuraghazra/github-readme-stats)
[![Anurag's GitHub stats](https://github-readme-stats.vercel.app/api?username=anuraghazra&hide_border=false)](https://github.com/anuraghazra/github-readme-stats)

@jgphilpott
Copy link
Author

Okay @rickstaa I see what has happened, there was a typo in my url that misspelled true as ture, oops! I guess it was previously evaluating to true anyway but is now evaluating to false. Thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants