Mark error context and objects inside those contexts as read-only #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Oct 29, 2025
Collaborator
Author
steveluscher
force-pushed
the
10-29-mark_error_context_and_objects_inside_those_contexts_as_read-only
branch
from
6e83a66 to
bbc363a
Compare
steveluscher
commented
Oct 29, 2025
Comment on lines
+49
to
+52
| // @ts-expect-error Context is read-only | ||
| e.context.addresses = [] as unknown as typeof e.context.addresses; | ||
| // @ts-expect-error Objects in context are read-only | ||
| e.context.addresses.push('abc' as unknown as (typeof e.context.addresses)[number]); |
Collaborator
Author
There was a problem hiding this comment.
I wanted to write a procedural test that looped over every object in SolanaErrorContext to assert that it's read-only, but I couldn't figure out how to. It seems that mutable objects always satisfies Readonly<object>.
Member
There was a problem hiding this comment.
I guess this is the same logic that lets us pass Uint8Array to our ReadonlyUint8Array. I think this approach looks fine!
steveluscher
commented
Oct 29, 2025
| actualVersion: number; | ||
| }; | ||
| } | ||
| export type SolanaErrorContext = ReadonlyContextValue< |
Collaborator
Author
There was a problem hiding this comment.
Made a little utility to make all of these Readonly.
steveluscher
force-pushed
the
10-29-mark_error_context_and_objects_inside_those_contexts_as_read-only
branch
from
bbc363a to
eb2a4c2
Compare
BundleMonFiles updated (3)
Unchanged files (127)
Total files change +70B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
force-pushed
the
10-29-mark_error_context_and_objects_inside_those_contexts_as_read-only
branch
from
eb2a4c2 to
eb0aa0f
Compare
Contributor
|
Documentation Preview: https://kit-docs-6jhle0l95-anza-tech.vercel.app |
steveluscher
force-pushed
the
10-29-mark_error_context_and_objects_inside_those_contexts_as_read-only
branch
from
eb0aa0f to
cddbcb1
Compare
mcintyre94
approved these changes
Oct 30, 2025
Comment on lines
+49
to
+52
| // @ts-expect-error Context is read-only | ||
| e.context.addresses = [] as unknown as typeof e.context.addresses; | ||
| // @ts-expect-error Objects in context are read-only | ||
| e.context.addresses.push('abc' as unknown as (typeof e.context.addresses)[number]); |
Member
There was a problem hiding this comment.
I guess this is the same logic that lets us pass Uint8Array to our ReadonlyUint8Array. I think this approach looks fine!
lorisleiva
approved these changes
Oct 30, 2025
Comment on lines
+614
to
+615
| expectedAddresses: readonly string[]; | ||
| unexpectedAddresses: readonly string[]; |
Member
There was a problem hiding this comment.
Since these context objects are now automatically readonly-fied, is the convention that we still prefix arrays and object with the readonly keyword? I'm happy either way but I think we should be consistent with this.
Collaborator
Author
There was a problem hiding this comment.
My utility is not recursive. It merely changed this:
type Foo = {
bar: readonly string[],
};to this:
type Foo = {
readonly bar: readonly string[],
};
steveluscher
deleted the
10-29-mark_error_context_and_objects_inside_those_contexts_as_read-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.