feat: Add clientId field to getClusterNodes response #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e508f9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
steveluscher
requested changes
Sep 2, 2025
Collaborator
steveluscher
left a comment
steveluscher
left a comment
There was a problem hiding this comment.
Make sure to update all of the tests (run pnpm dev in packages/rpc-api/ as you work) and to add an exemption for clientId so that the client doesn't presume it's supposed to be a BigInt.
See #521 for a great example of how to do all of that!
BundleMonUnchanged files (130)
Total files change +33B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
Author
|
Hey, I updated and fixed a lint, where the |
Collaborator
|
Cool. Tests are failing merely because the current validator does not return |
steveluscher
requested review from
alannza and
steveluscher
and removed request for
steveluscher
Author
|
Why was this one closed? |
mcintyre94
added
do-not-close
Member
|
Sorry @leafaar - I think we should have marked this do-not-close so the bot doesn't close it. Reopened and added that label, hopefully it'll be left alone now! We have a github action that closes stale issues/PRs automatically: https://github.com/anza-xyz/kit/blob/main/.github/workflows/manage-stale-threads.yml |
Author
|
No problem, thank you 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Agave RPC now returns a
clientIdfield in the getClusterNodes response (see anza-xyz/agave#7817), but the JavaScript client doesn't include this field in its type definitions.Summary of Changes
clientId: number | nullfield to theClusterNodetypeReferences