feat: 🎸 Improved QueryObject to handle more fields #116
Conversation
The commit is to ensure the feature parity between frontend and backend QueryOjbect
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 74 74
Lines 898 923 +25
Branches 211 224 +13
=====================================
+ Hits 898 923 +25
Continue to review full report at Codecov.
|
| @@ -29,24 +29,31 @@ export default class Metrics { | |||
| return this.metrics.map(m => m.label); | |||
| } | |||
|
|
|||
| private addMetric(metric: FormDataMetric) { | |||
| static convertMetric(metric: FormDataMetric): Metric { | |||
There was a problem hiding this comment.
could we call this cleanMetric or something more descriptive? at first glance it's not clear what it's converting to or from
| row_limit?: number; | ||
| order_desc?: boolean; | ||
| is_timeseries?: boolean; | ||
| prequeries?: any[]; |
There was a problem hiding this comment.
can prequeries, extras, and orderby by something besides any?
| where: formData.where || '', | ||
| }; | ||
|
|
||
| const orgGroupby = formData.groupby || []; |
There was a problem hiding this comment.
I wasn't sure what org meant for these vars initially, could just extract like
const { columns = [], groupby = [] } = formData;
// OR
const groupbySet = new Set([ ...formData.columns, ...formData.groupby ]);| const orgGroupby = formData.groupby || []; | ||
| const orgColumns = formData.columns || []; | ||
| const groupbySet = new Set(orgGroupby.concat(orgColumns)); | ||
| const limit = formData.limit ? Number(formData.limit) : 0; |
There was a problem hiding this comment.
does limit=0 have any weird query side effects?
There was a problem hiding this comment.
This is the original logic from viz.py:
limit = int(form_data.get('limit') or 0)
|
back too 100% ! |
|
should I merge this PR? @williaster |
🏆 Enhancements
The commit is to ensure the feature parity between frontend and backend
QueryOjbect