Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: broken build due to failing unit tests #141

Merged
merged 4 commits into from
Apr 26, 2019
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Apr 26, 2019

🐛 Bug Fix

  • Replace response.body direct access which returns stream data input with response.text() which converts the data stream into single string (but returns Promise<string>).
    The main changes are
    • firstResponse.body => firstResponse.text()
    • secondResponse.body=> secondResponse.text()
    • response.body => secondResponse.text().
  • Also change the code to async/await for readability as there are many Promise nesting.

@kristw kristw requested a review from a team as a code owner April 26, 2019 23:07
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #141 into master will increase coverage by 0.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #141     +/-   ##
=======================================
+ Coverage   99.19%   100%   +0.8%     
=======================================
  Files          77     77             
  Lines         988    988             
  Branches      238    238             
=======================================
+ Hits          980    988      +8     
+ Misses          6      0      -6     
+ Partials        2      0      -2
Impacted Files Coverage Δ
...ages/superset-ui-connection/src/callApi/callApi.ts 100% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2525707...382e07a. Read the comment docs.

@netlify
Copy link

netlify bot commented Apr 26, 2019

Deploy preview for superset-ui ready!

Built with commit 382e07a

https://deploy-preview-141--superset-ui.netlify.com

@kristw kristw merged commit 58d56d5 into master Apr 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--fix-unit-test branch April 26, 2019 23:50
kristw pushed a commit that referenced this pull request Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants