This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 272
refactor(chart): remove and rename fields in ChartProps #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for superset-ui ready! Built with commit 3dfe5dd |
kristw
changed the title
[WIP] refactor(chart): remove and remove fields in ChartProps
[WIP] refactor(chart): remove and rename fields in ChartProps
Jun 18, 2019
kristw
force-pushed
the
kristw--chartp
branch
2 times, most recently
from
August 13, 2019 19:51
2656f4d
to
a587d63
Compare
kristw
changed the title
[WIP] refactor(chart): remove and rename fields in ChartProps
refactor(chart): remove and rename fields in ChartProps
Aug 13, 2019
BREAKING CHANGE: ChartProps fields are removed and renamed.
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 99.91% 99.91% +<.01%
==========================================
Files 102 107 +5
Lines 1222 1240 +18
Branches 293 305 +12
==========================================
+ Hits 1221 1239 +18
Partials 1 1
Continue to review full report at Codecov.
|
kristw
changed the title
refactor(chart): remove and rename fields in ChartProps
refactor(chart): remove and rename props of SuperChart
Aug 14, 2019
kristw
changed the title
refactor(chart): remove and rename props of SuperChart
refactor(chart): remove and rename fields in ChartProps
Aug 14, 2019
etr2460
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
BREAKING CHANGE: ChartProps fields are removed and renamed.
The functions (
onAddFilter
,onError
,setControlValue
,setTooltip
) are nested underhooks
because these are used primarily in Superset app and has no use for other apps.annotationData
annotationData
datasource
datasource
filters
initialValues
filters
was misleading because it is actually initial values of thefilter_box
andtable vis
.formData
formData
hooks
hooks
onAddFilter
hooks.onAddFilter
onError
hooks.onError
payload
queryData
payload
is ambiguoussetControlValue
hooks.setControlValue
setTooltip
hooks.setTooltip
width
width
height
height
Only merge this when we are ready to publish it along with other breaking changes.