Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(legacy-plugin-chart-country-map): migrate and replace india map #376

Merged
merged 6 commits into from
Apr 17, 2020

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Apr 17, 2020

🏆 Enhancements

Migrate country-map. The old india geojson file was 76MB!!! Optimize the file and replaced it with a 457KB file.

@kristw kristw requested a review from a team as a code owner April 17, 2020 09:55
@vercel
Copy link

vercel bot commented Apr 17, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/superset/superset-ui/c3o232enj
✅ Preview: https://superset-ui-git-kristw-country.superset.now.sh

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #376 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #376      +/-   ##
=========================================
- Coverage    3.15%   3.07%   -0.08%     
=========================================
  Files          79      83       +4     
  Lines        3899    3994      +95     
  Branches      146     146              
=========================================
  Hits          123     123              
- Misses       3747    3842      +95     
  Partials       29      29              
Impacted Files Coverage Δ
.../legacy-plugin-chart-country-map/src/CountryMap.js 0.00% <0.00%> (ø)
...s/legacy-plugin-chart-country-map/src/countries.js 0.00% <ø> (ø)
...ugins/legacy-plugin-chart-country-map/src/index.js 0.00% <ø> (ø)
...acy-plugin-chart-country-map/src/transformProps.js 0.00% <ø> (ø)
...l-coordinates/src/vendor/parcoords/d3.parcoords.js 0.00% <0.00%> (ø)
...rallel-coordinates/src/vendor/parcoords/divgrid.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c8cbd8...b1291eb. Read the comment docs.

@ktmud
Copy link
Contributor

ktmud commented Apr 17, 2020

There are no stories for this plugin?

@kristw
Copy link
Contributor Author

kristw commented Apr 17, 2020

storybook migrated

@kristw kristw merged commit 21a35f3 into master Apr 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the kristw--country branch April 17, 2020 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants