Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(plugin-word-cloud): change how wordcloud is exported #418

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Apr 29, 2020

💔 Breaking Changes

Old behavior

exports default WordCloudChartPlugin from index.

import WordCloudChartPlugin from '@superset-ui/plugin-chart-word-cloud';

users need to deep import /esm/legacy to get the legacy version.

import LegacyWordCloudChartPlugin from '@superset-ui/plugin-chart-word-cloud/esm/legacy';

New behavior

exports both WordCloudChartPlugin and LegacyWordCloudChartPlugin from index.

import { WordCloudChartPlugin, LegacyWordCloudChartPlugin } from '@superset-ui/plugin-chart-word-cloud';

@kristw kristw requested a review from a team as a code owner April 29, 2020 19:57
@vercel
Copy link

vercel bot commented Apr 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/mpj84zhsq
✅ Preview: https://superset-ui-git-kristw-word-cloud.superset.now.sh

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #418 into master will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   22.25%   22.28%   +0.03%     
==========================================
  Files         261      261              
  Lines        6474     6474              
  Branches      587      587              
==========================================
+ Hits         1441     1443       +2     
+ Misses       4996     4994       -2     
  Partials       37       37              
Impacted Files Coverage Δ
.../plugin-chart-word-cloud/src/legacyPlugin/index.ts 33.33% <ø> (ø)
...hart-word-cloud/src/legacyPlugin/transformProps.ts 54.54% <ø> (ø)
...s/plugin-chart-word-cloud/src/plugin/buildQuery.ts 100.00% <ø> (ø)
...ugin-chart-word-cloud/src/plugin/transformProps.ts 0.00% <ø> (ø)
...lugins/plugin-chart-word-cloud/src/plugin/index.ts 33.33% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba12f7...fcc53f8. Read the comment docs.

@kristw kristw merged commit c5d3893 into master Apr 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the kristw--word-cloud branch April 29, 2020 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants