feat(legacy-plugin-chart-big-number): add control panel config for the BigNumber charts #419
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/q3z065qxl |
| @@ -18,6 +18,7 @@ | |||
| */ | |||
| import { t } from '@superset-ui/translation'; | |||
| import { ChartMetadata, ChartPlugin } from '@superset-ui/chart'; | |||
| import controlPanel from './controls'; | |||
There was a problem hiding this comment.
Let's name the file controlPanel so it is the same when imported.
| D3_TIME_FORMAT_OPTIONS, | ||
| D3_FORMAT_DOCS, | ||
| D3_FORMAT_OPTIONS, | ||
| } from '@superset-ui/chart'; |
There was a problem hiding this comment.
Please see #417. May have to change reference after that one is merged.
There was a problem hiding this comment.
Let's merge that and I'll rebase
| @@ -338,6 +341,7 @@ export const timeSeriesSection = [ | |||
| 'of query results', | |||
| ), | |||
| controlSetRows: [ | |||
| // eslint-disable-next-line react/jsx-key | |||
There was a problem hiding this comment.
Can move this to top of the file to disable for the whole file.
And just FYI, VS Code allows you to do this in on click:
There was a problem hiding this comment.
I'm wary of disabling rules for a whole file, it's safer to do it per-line.
There was a problem hiding this comment.
For this particular case, I don't understand why the rule needs to be disabled though. I see no real code change and it certainly has passed previous CI check?
There was a problem hiding this comment.
previously it was in the temporary-plugins dir which is excluded from CI build and tests
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
=========================================
- Coverage 3.10% 3.08% -0.02%
=========================================
Files 148 151 +3
Lines 5192 5217 +25
Branches 272 273 +1
=========================================
Hits 161 161
- Misses 4994 5019 +25
Partials 37 37
Continue to review full report at Codecov.
|
suddjian
force-pushed
the
bignumber-controls
branch
from
f8641a2 to
88a623a
Compare
|
Addressed PR feedback |
plugins/big-number/package.json
Outdated
| @@ -37,6 +37,7 @@ | |||
| "peerDependencies": { | |||
| "@superset-ui/chart": "^0.13.0", | |||
| "@superset-ui/color": "^0.13.0", | |||
| "@superset-ui/control-utils": "^0.0.0", | |||
There was a problem hiding this comment.
This should be ^0.13.0 now.
kristw
changed the title
💔 Breaking Changes
🏆 Enhancements
Allows BigNumber to register its own controls, so that the control configs can be removed from superset.
📜 Documentation
🐛 Bug Fix
🏠 Internal