Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(legacy-plugin-world-map): set useLegacyApi to true by default #444

Merged

Conversation

villebro
Copy link
Contributor

@villebro villebro commented May 6, 2020

🐛 Bug Fix

The World Map plugin is currently failing if the new chart data API is enabled in Superset due to useLegacyApi not being explicitly set to true.

@rusackas @kristw @suddjian @ktmud

@villebro villebro requested a review from a team as a code owner May 6, 2020 07:24
@vercel
Copy link

vercel bot commented May 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/jr6t0bzyl
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-world-map-legacy-api.superset.now.sh

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   22.20%   22.20%           
=======================================
  Files         264      264           
  Lines        6500     6500           
  Branches      588      588           
=======================================
  Hits         1443     1443           
  Misses       5020     5020           
  Partials       37       37           
Impacted Files Coverage Δ
plugins/legacy-plugin-chart-world-map/src/index.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86847d1...df06fdb. Read the comment docs.

@ktmud ktmud merged commit 3b9c478 into apache-superset:master May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants