Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(chart): adjust chartclient to point to new endpoints #551

Merged
merged 5 commits into from
May 30, 2020

Conversation

kristw
Copy link
Contributor

@kristw kristw commented May 29, 2020

🐛 Bug Fix

Update according to the new endpoints.

@kristw kristw requested a review from a team as a code owner May 29, 2020 22:52
@vercel
Copy link

vercel bot commented May 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/qjizh2jm9
✅ Preview: https://superset-ui-git-kristw-chart-client.superset.now.sh

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm

@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #551 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   23.14%   23.13%   -0.02%     
==========================================
  Files         290      290              
  Lines        6784     6783       -1     
  Branches      676      676              
==========================================
- Hits         1570     1569       -1     
  Misses       5176     5176              
  Partials       38       38              
Impacted Files Coverage Δ
...kages/superset-ui-chart/src/clients/ChartClient.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac09d8...fe11f90. Read the comment docs.

@kristw kristw merged commit bbc42c2 into master May 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the kristw--chart-client branch May 30, 2020 00:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants