build: migrate to nimbus #281

kristw · 2020-01-22T08:45:43Z

🏠 Internal

Fix Can not build in project with 0.12.1 #265
Use build configuration from nimbus, which is a shareable build config for jest, babel, eslint, prettier, and typescript on top of beemo.
Fix hundreds of new lint and ts issues. Disable some eslint rules for test files at the moment.

Notable overrides

Set timer to real (jest's default) instead of nimbus's default which uses fake timer. For unknown reason, jest.useRealTimers() has no effect if the default timer is fake. On the other hand, if the default timer is real, jest.useFakeTimers() works fine.
Stop eslint from auto-fixing the no-explicit-any rule and convert all any into (the) unknown. 🎶❄️

package.json

netlify · 2020-01-22T21:31:13Z

Deploy preview for superset-ui ready!

Built with commit 5b3b321

https://deploy-preview-281--superset-ui.netlify.com

netlify · 2020-01-22T21:38:40Z

Deploy preview for superset-ui ready!

Built with commit f950af6

https://deploy-preview-281--superset-ui.netlify.com

(cherry picked from commit 22328c3)

(cherry picked from commit dd55fd8)

codecov · 2020-01-24T07:56:38Z

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #281   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         104    102    -2     
  Lines        1234   1212   -22     
  Branches      296    298    +2     
=====================================
- Hits         1234   1212   -22

Impacted Files	Coverage Δ
packages/superset-ui-time-format/src/utils.ts	`100% <ø> (ø)`	⬆️
...kages/superset-ui-query/src/types/QueryFormData.ts	`100% <ø> (ø)`	⬆️
...ages/superset-ui-dimension/src/getTextDimension.ts	`100% <ø> (ø)`	⬆️
test/setup.ts	`100% <ø> (ø)`
...er-format/src/factories/createD3NumberFormatter.ts	`100% <ø> (ø)`	⬆️
...uperset-ui-color/src/colorSchemes/sequential/d3.ts	`100% <ø> (ø)`	⬆️
...set-ui-color/src/colorSchemes/sequential/common.ts	`100% <ø> (ø)`	⬆️
...s/superset-ui-translation/test/languagePacks/en.ts	`100% <ø> (ø)`
...et-ui-color/src/colorSchemes/categorical/google.ts	`100% <ø> (ø)`	⬆️
...rset-ui-chart/src/components/ChartDataProvider.tsx	`100% <ø> (ø)`	⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0498386...f950af6. Read the comment docs.

kristw · 2020-01-28T01:23:25Z

cc @etr2460 finally got a green CI

williaster · 2020-01-28T18:35:42Z

finally looking at this, thanks for all the effort/pain 🙏

williaster

LGTM overall, had a few thoughts that could be worth fixing before merge. thanks again! 💖

package.json

williaster · 2020-01-28T18:52:18Z

packages/superset-ui-chart-composition/src/ChartFrame.tsx

@@ -35,8 +35,8 @@ export default class ChartFrame extends PureComponent<Props, {}> {
          }}
        >
          {renderContent({
-            height: Math.max(contentHeight || 0, height),
-            width: Math.max(contentWidth || 0, width),
+            height: Math.max(contentHeight ?? 0, height),


@etr2460 added these internally and although the build passed it threw errors in the app. might be worth testing (I guess if preview works it should be good)

This sounds scary. I checked the storybook previews and they work correctly.
What are the issues that appear in app? I could try to revert back to || and suppress eslint if it is risky.

you need to make sure that babel updated to handle the new syntax. babel 7.8.3 should do the trick.

packages/superset-ui-chart/package.json

packages/superset-ui-number-format/test/factories/createSmartNumberFormatter.test.ts

packages/superset-ui-number-format/test/factories/createSiAtMostNDigitFormatter.test.ts

packages/superset-ui-dimension/test/getMultipleTextDimensions.test.ts

packages/superset-ui-dimension/src/getTextDimension.ts

packages/superset-ui-chart/test/components/createLoadableRenderer.test.tsx

packages/superset-ui-chart/test/components/SuperChart.test.tsx

kristw added 3 commits January 22, 2020 00:07

build: migrate to nimbus

d2c7dc0

build: update gitignore

9be0d9a

build: update package.json

d6fe95c

kristw requested a review from a team as a code owner January 22, 2020 08:45

pull-request-size bot added the size/L label Jan 22, 2020

kristw added 3 commits January 22, 2020 00:47

build: update travis config

db9f99c

build: lower engine requirements

4eae375

build: adjust typescript config

9e0b5d5

williaster reviewed Jan 22, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

kristw added 2 commits January 22, 2020 13:23

fix: errors

5b3b321

fix: change yarn run to yarn

d65d44b

pull-request-size bot added size/XXL and removed size/L labels Jan 22, 2020

kristw mentioned this pull request Jan 23, 2020

Can not build in project with 0.12.1 #265

Closed

kristw added 7 commits January 23, 2020 17:18

fix: lint

158f77b

(cherry picked from commit 22328c3)

fix: eslint rules

e04a63c

fix: lint

ac6054a

fix: setup file

ba58dc2

fix: more lint

bc3a926

fix: lint - pass build and lint

8a9cc8a

fix: test setup and babel transform runtime

3be990b

(cherry picked from commit dd55fd8)

kristw force-pushed the kristw--nimbus branch from 95a9e47 to 3be990b Compare January 24, 2020 07:44

kristw added 5 commits January 24, 2020 02:24

fix: timeout issues

d1d0a63

fix: some broken test due to jest.setTimeout

88d5d66

fix: computeMaxFontSize tests

f4d9e51

fix: createLoadableRenderer test

3d1266f

fix: loadble and broken tests due to warnings

60d42bf

kristw added 4 commits January 24, 2020 18:08

fix: test coverage

b2d73e0

fix: coverage of generator tests

4e3ad79

fix: all unit tests pass

556971e

fix: remove yeutech-lab/react-loadable

f950af6

williaster approved these changes Jan 28, 2020

View reviewed changes

kristw mentioned this pull request Jan 28, 2020

Make test in @superset-ui/dimension use fake timers #286

Closed

kristw merged commit dc804b7 into master Jan 28, 2020

delete-merged-branch bot deleted the kristw--nimbus branch January 28, 2020 23:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: migrate to nimbus #281

build: migrate to nimbus #281

kristw commented Jan 22, 2020 •

edited

Loading

netlify bot commented Jan 22, 2020

netlify bot commented Jan 22, 2020 •

edited

Loading

codecov bot commented Jan 24, 2020 •

edited

Loading

kristw commented Jan 28, 2020

williaster commented Jan 28, 2020

williaster left a comment

williaster Jan 28, 2020

williaster Jan 28, 2020

kristw Jan 28, 2020

etr2460 Jan 28, 2020

build: migrate to nimbus #281

build: migrate to nimbus #281

Conversation

kristw commented Jan 22, 2020 • edited Loading

netlify bot commented Jan 22, 2020

netlify bot commented Jan 22, 2020 • edited Loading

codecov bot commented Jan 24, 2020 • edited Loading

Codecov Report

kristw commented Jan 28, 2020

williaster commented Jan 28, 2020

williaster left a comment

Choose a reason for hiding this comment

williaster Jan 28, 2020

Choose a reason for hiding this comment

williaster Jan 28, 2020

Choose a reason for hiding this comment

kristw Jan 28, 2020

Choose a reason for hiding this comment

etr2460 Jan 28, 2020

Choose a reason for hiding this comment

kristw commented Jan 22, 2020 •

edited

Loading

netlify bot commented Jan 22, 2020 •

edited

Loading

codecov bot commented Jan 24, 2020 •

edited

Loading