diff --git a/.github/workflows/additional-ci-image-checks.yml b/.github/workflows/additional-ci-image-checks.yml index e3f8a4c634e02..7d0eb88d24130 100644 --- a/.github/workflows/additional-ci-image-checks.yml +++ b/.github/workflows/additional-ci-image-checks.yml @@ -112,7 +112,7 @@ jobs: use-uv: "true" include-success-outputs: ${{ inputs.include-success-outputs }} docker-cache: ${{ inputs.docker-cache }} - if: inputs.canary-run == 'true' && inputs.branch == 'main' + if: inputs.branch == 'main' # Check that after earlier cache push, breeze command will build quickly check-that-image-builds-quickly: @@ -127,7 +127,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_USERNAME: ${{ github.actor }} VERBOSE: "true" - if: inputs.canary-run == 'true' && inputs.branch == 'main' + if: inputs.branch == 'main' steps: - name: "Cleanup repo" shell: bash @@ -168,4 +168,3 @@ jobs: use-uv: "true" upgrade-to-newer-dependencies: ${{ inputs.upgrade-to-newer-dependencies }} docker-cache: ${{ inputs.docker-cache }} - if: inputs.canary-run == 'true' diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dc9f1305fb521..9572ff14275a6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -237,6 +237,7 @@ jobs: name: "Additional CI image checks" needs: [build-info, wait-for-ci-images] uses: ./.github/workflows/additional-ci-image-checks.yml + if: needs.build-info.outputs.canary-run == 'true' with: runs-on-as-json-default: ${{ needs.build-info.outputs.runs-on-as-json-default }} runs-on-as-json-public: ${{ needs.build-info.outputs.runs-on-as-json-public }} @@ -441,6 +442,11 @@ jobs: contents: read packages: read secrets: inherit + if: > + needs.build-info.outputs.run-tests == 'true' && + (needs.build-info.outputs.canary-run == 'true' || + needs.build-info.outputs.upgrade-to-newer-dependencies != 'false' || + needs.build-info.outputs.full-tests-needed == 'true') with: runs-on-as-json-default: ${{ needs.build-info.outputs.runs-on-as-json-default }} image-tag: ${{ needs.build-info.outputs.image-tag }} @@ -451,7 +457,6 @@ jobs: canary-run: ${{ needs.build-info.outputs.canary-run }} upgrade-to-newer-dependencies: ${{ needs.build-info.outputs.upgrade-to-newer-dependencies }} debug-resources: ${{ needs.build-info.outputs.debug-resources }} - if: needs.build-info.outputs.run-tests == 'true' tests-integration: name: Integration Tests @@ -601,8 +606,8 @@ jobs: - tests-mysql - tests-postgres - tests-non-db - - tests-special - tests-integration + - tests-special uses: ./.github/workflows/finalize-tests.yml with: runs-on-as-json-public: ${{ needs.build-info.outputs.runs-on-as-json-public }} diff --git a/.github/workflows/special-tests.yml b/.github/workflows/special-tests.yml index 26fb0d3ac1d11..87012ade014c7 100644 --- a/.github/workflows/special-tests.yml +++ b/.github/workflows/special-tests.yml @@ -64,7 +64,6 @@ jobs: contents: read packages: read secrets: inherit - if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true' with: runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }} downgrade-sqlalchemy: "true" @@ -87,7 +86,6 @@ jobs: contents: read packages: read secrets: inherit - if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true' with: runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }} upgrade-boto: "true" @@ -110,7 +108,6 @@ jobs: contents: read packages: read secrets: inherit - if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true' with: runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }} pydantic: "v1" @@ -133,7 +130,6 @@ jobs: contents: read packages: read secrets: inherit - if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true' with: runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }} pydantic: "none" @@ -156,7 +152,6 @@ jobs: contents: read packages: read secrets: inherit - if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true' with: runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }} downgrade-pendulum: "true" @@ -179,7 +174,6 @@ jobs: contents: read packages: read secrets: inherit - if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true' with: runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }} enable-aip-44: "false" @@ -202,7 +196,6 @@ jobs: contents: read packages: read secrets: inherit - if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true' with: runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }} test-name: "Postgres" @@ -224,7 +217,6 @@ jobs: contents: read packages: read secrets: inherit - if: inputs.canary-run == 'true' || inputs.upgrade-to-newer-dependencies == 'true' with: runs-on-as-json-default: ${{ inputs.runs-on-as-json-default }} test-name: "Postgres"