Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseBranchOperator isn't used anywhere #11931

Closed
RosterIn opened this issue Oct 29, 2020 · 2 comments
Closed

BaseBranchOperator isn't used anywhere #11931

RosterIn opened this issue Oct 29, 2020 · 2 comments
Labels

Comments

@RosterIn
Copy link
Contributor

This is not a bug but more a question/observation about BaseBranchOperator that was added in #5231

Both BranchPythonOperator and BranchSQLOperator inherit from BaseOperator and not from BaseBranchOperator

So what BaseBranchOperator is used for? only for custom user branching operator? It's a bit odd that Airflow has 2 branching operators that don't use the Base.

The interesting part is that it used to be the parent class of BranchSQLOperator in the previous path of sql_branch_operator.py but was changed for some reason.

@RosterIn RosterIn added the kind:bug This is a clearly a bug label Oct 29, 2020
@mik-laj
Copy link
Member

mik-laj commented Oct 29, 2020

@RosterIn This is used to express your own business logic.

@eladkal
Copy link
Contributor

eladkal commented Mar 11, 2021

It is being used:

class BranchDayOfWeekOperator(BaseBranchOperator):

class DateTimeBranchOperator(BaseBranchOperator):

@eladkal eladkal closed this as completed Mar 11, 2021
@eladkal eladkal added invalid and removed kind:bug This is a clearly a bug labels Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants