Make helm chart commands compatible with 1.10.14 image

[dstandish]

["airflow", "webserver"] does not work with apache/airflow:1.10.14

["webserver"] works, as does ["bash", "-c", ...] as done in this PR

i tested with both 1.10.14 and 2.0.0 but no earlier versions

[ashb]

Using exec means we don't have a "needless" bash process hanging around.

[xinbinhuang]

Using exec means we don't have a "needless" bash process hanging around.

Just a small note: without the exec, bash will be the PID 1, and the airflow process may not exit properly upon container exit. But I think dumb-init takes care of it in our case.

[dstandish]

@xinbinhuang i am testing this with 1.10.14 and seeing bad termination behavior of celery workers. documented here: #13591

perhaps you have some insight?

[xinbinhuang]

@xinbinhuang i am testing this with 1.10.14 and seeing bad termination behavior of celery workers. documented here: #13591

perhaps you have some insight?

Does ["bash", "-c", "exec airflow scheduler"] work for your case?

I have a feeling that the current PR does not do anything differently because ["airflow", "scheduler"] is essentially the same as ["bash", "-c", "exec airflow scheduler"].
As for ["bash", "-c", "airflow webserver"] is working, it's probably due to the fact that Docker does not signal the process properly which leaves it hanging, making it feels like a "graceful termination".

I will comment further on the original issue

[dstandish]

have a feeling that the current PR does not do anything differently

the issue @xinbinhuang is how entrypoint handles bash vs airflow

try to run 1.10.14 with this chart and you'll see

[dstandish]

and to clarify, this PR is not about worker termination -- its just about making 1.10.14 run at all

but in some testing i noticed termination issue, which doesn't seem to have been working before anyway.

[dstandish]

@ashb i think i resolved your concerns