[AIRFLOW-185][AIRFLOW-187] PR tool fixes/updates #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowin
force-pushed
the
pr-tool-5
branch
3 times, most recently
from
c460e25 to
095c300
Compare
| but the squashed commit will still be attributed to the PR author. | ||
| GitHub will show that you merged the squash commit but will mark the PR | ||
| as closed rather than merged (the distinction is | ||
| puerly cosmetic). |
There was a problem hiding this comment.
Nit: puerly typo, and newline seems erroneous here
|
LGTM just a couple of nits |
- Add command to setup_git_remotes - Add guard for running PR tool in a branch with uncommitted changes - Add option to edit squash commit message - Message styling for clarity - Improved error messages for PR Tool problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:
185:
187: