Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected bug in exiting PSRPHook.client context manager #18014

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

malthe
Copy link
Contributor

@malthe malthe commented Sep 3, 2021

This fixes a minor code issue (which rendered the hook unusable).

@ashb
Copy link
Member

ashb commented Sep 3, 2021

This is where the "autospec" feature of Mock comes in very handy! (Though I'm not sure if this is usable in this particular case)

@ashb ashb changed the title Fix unexpected bug in exiting hook context manager Fix unexpected bug in exiting PSRPHook.client context manager Sep 3, 2021
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 3, 2021
@potiuk potiuk merged commit 9c64419 into apache:main Sep 3, 2021
@potiuk
Copy link
Member

potiuk commented Sep 3, 2021

Great. I will release a new psrp provider version today then - together with hashicorp and celery I have to release. Then I will yank the 1.0.0 version of psrp (makes no sense to yank it because there is only one versin so yanking will not have effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants