Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try/except when closing temporary file in task_runner #18269

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Use try/except when closing temporary file in task_runner #18269

merged 1 commit into from
Sep 15, 2021

Commits on Sep 15, 2021

  1. Use try/except when closing temporary file in task_runner 

    Occasionally we get FileNotFoundError when calling close on the named temporary file,
the reason I believe is that the file has been removed by the subprocess before we call
close on it.

When NamedTemporary file is instantiated  with delete=True, calling close on the file deletes the file

This PR adds a try/except when calling the close method to capture the error
    @ephraimbuddy
    ephraimbuddy committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    03671c8 View commit details
    Browse the repository at this point in the history