Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emr cluster link #18691

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Conversation

anaynayak
Copy link
Contributor

Add an operator link to EMR cluster on AWS Console.

Notes:

  1. Followed a similar structure to other operators like DataprocClusterLink
  2. Noticed that the tests were a mix of pytest +unittest. Haven't moved the rest of the tests to pytest. Can attempt to do this if it helps.
  3. Wasn't sure what all tests to run.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 3, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@anaynayak
Copy link
Contributor Author

Rebased against latest main. I believe the build for the earlier one had failed due to conflicting dependencies (unrelated to this change)

@anaynayak anaynayak changed the title Feature add emr cluster link Add emr cluster link Oct 4, 2021
@potiuk potiuk merged commit 1a35644 into apache:main Oct 8, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 8, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants