Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AWS Secrets Manager backend to retrieve conns using different fields #18764

Merged
merged 8 commits into from
Oct 8, 2021

Conversation

JavierLopezT
Copy link
Contributor

Fixing bugs for rc2 release

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced this is needed.

I think the problem is that example had invalid JSON, ({"x": True} is not valid JSON) so as a result of this code

try:
alternative_secrets_config_dict = json.loads(
conf.get(section='secrets', key='backend_kwargs', fallback='{}')
)
except JSONDecodeError:
alternative_secrets_config_dict = {}
it ended up silently ignoring the config you tried.

@ashb ashb closed this Oct 6, 2021
@ashb ashb reopened this Oct 6, 2021
@ashb
Copy link
Member

ashb commented Oct 6, 2021

I see there is one tiny change in here, but the rest of the changes need reverting.

@JavierLopezT
Copy link
Contributor Author

I'm not convinced this is needed.

I think the problem is that example had invalid JSON, ({"x": True} is not valid JSON) so as a result of this code

try:
alternative_secrets_config_dict = json.loads(
conf.get(section='secrets', key='backend_kwargs', fallback='{}')
)
except JSONDecodeError:
alternative_secrets_config_dict = {}

it ended up silently ignoring the config you tried.

Ok, I didn't know that. I searched for this but I couldn't find it. Thank you very much. I'll make changes accordingly

@potiuk potiuk requested a review from ashb October 6, 2021 15:01
@potiuk potiuk closed this Oct 7, 2021
@potiuk potiuk reopened this Oct 7, 2021
@potiuk
Copy link
Member

potiuk commented Oct 7, 2021

Closed/Reopened as there was temp 503 on static checks schema. @ashb -> would love to get the final review to release amazon provider before ~ during voting for 2.2 so that we can build 2.2 image with it :)

@JavierLopezT JavierLopezT reopened this Oct 7, 2021
@potiuk
Copy link
Member

potiuk commented Oct 7, 2021

The failure is not a problem. @ashb -> ok to merge it ?

@potiuk potiuk closed this Oct 8, 2021
@potiuk potiuk reopened this Oct 8, 2021
@potiuk potiuk requested a review from ashb October 8, 2021 05:32
@zachliu
Copy link
Contributor

zachliu commented Oct 8, 2021

one question:
should we adjust the default behavior of "full_url_mode" to true?
otherwise this could break existing processes 🤔

@JavierLopezT
Copy link
Contributor Author

one question: should we adjust the default behavior of "full_url_mode" to true? otherwise this could break existing processes 🤔

It is true by default.

@zachliu
Copy link
Contributor

zachliu commented Oct 8, 2021

one question: should we adjust the default behavior of "full_url_mode" to true? otherwise this could break existing processes thinking

It is true by default.

oops, i must have mixed

with the docs.

thanks for clarifying 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:secrets kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants