-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AWS Secrets Manager backend to retrieve conns using different fields #18764
Conversation
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this is needed.
I think the problem is that example had invalid JSON, ({"x": True}
is not valid JSON) so as a result of this code
airflow/airflow/configuration.py
Lines 1031 to 1036 in c9bf5f3
try: | |
alternative_secrets_config_dict = json.loads( | |
conf.get(section='secrets', key='backend_kwargs', fallback='{}') | |
) | |
except JSONDecodeError: | |
alternative_secrets_config_dict = {} |
I see there is one tiny change in here, but the rest of the changes need reverting. |
Ok, I didn't know that. I searched for this but I couldn't find it. Thank you very much. I'll make changes accordingly |
Closed/Reopened as there was temp 503 on static checks schema. @ashb -> would love to get the final review to release |
The failure is not a problem. @ashb -> ok to merge it ? |
one question: |
It is true by default. |
oops, i must have mixed
with the docs. thanks for clarifying 👍 |
Fixing bugs for rc2 release