Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to move "dangling" rows in upgradedb #18953

Merged
merged 5 commits into from
Oct 14, 2021
Merged

Try to move "dangling" rows in upgradedb #18953

merged 5 commits into from
Oct 14, 2021

Commits on Oct 14, 2021

  1. Try to move "dangling" rows in upgradedb 

    Instead of failing loudly for invalid records (which happens way too
often), this attempts to move those offending data to another table and
carry on with the migration if possible. This table for dangling data
are copied with CREATE TABLE ... AS SELECT ... and could miss some
indexing and stuff, but this is only meant for temporary storage, so
this is probably not a big deal. If copying went well, the dangling
data are automatically deleted so we can carry on with migration.

Additionally, this commit removes the upgrade check on TaskFail, and
added check on TaskReschedule. This is because TaskFail is not actually
being migrated in 2.2, while TaskReschedule is, and we concluded this
is likely a typo during implementation and not an intentional choice.
    @uranusjr
    uranusjr committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    f73720a View commit details
    Browse the repository at this point in the history

  2. Change dangling table name to be more generic

    @uranusjr
    uranusjr committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    3d65d9f View commit details
    Browse the repository at this point in the history

  3. Look for "moved data" tables and show alert in UI

    @uranusjr
    uranusjr committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    e89ebbb View commit details
    Browse the repository at this point in the history

  4. Bump expected db call on /home for dangling table inspection

    @uranusjr
    uranusjr committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    2d08386 View commit details
    Browse the repository at this point in the history

  5. Wording

    @uranusjr
    uranusjr committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    4f70f7d View commit details
    Browse the repository at this point in the history