Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup string concatenations #19099

Merged
merged 12 commits into from
Oct 21, 2021
Merged

Conversation

blag
Copy link
Contributor

@blag blag commented Oct 20, 2021

This PR just fixes a few string concatenations here and there. Please pay particular attention to the regexes that I tweaked.

I may have been a little overzealous with my changes, namely:

  • It seems like sometimes explicit string concatenation was done to differentiate a line from its surroundings. I'm not sure if we want to keep things that way, or force everything to use implicit concatenation.
  • I also reformatted some of the SQL statements to (IMO) make them a bit more readable.

I also updated the tabulate dependency from 0.8.7 to 0.8.8 to fix an issue when attempting to run unit tests under Python 3.10. Those tests still fail for other reasons but this is one less speed bump when we add that, however, I'm not sure if including that change is appropriate in this PR.

@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow area:dev-tools area:providers provider:Apache provider:amazon-aws AWS/Amazon - related issues labels Oct 20, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 20, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 20, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

airflow/models/dagcode.py Outdated Show resolved Hide resolved
airflow/operators/google_api_to_s3_transfer.py Outdated Show resolved Hide resolved
airflow/providers/databricks/hooks/databricks.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/utils/eks_test_constants.py Outdated Show resolved Hide resolved
@jedcunningham jedcunningham merged commit f5ad26d into apache:main Oct 21, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 21, 2021

Awesome work, congrats on your first merged pull request!

@jedcunningham jedcunningham deleted the fix-string-concats branch October 21, 2021 22:56
@jedcunningham
Copy link
Member

@blag, congrats on your first commit 🍺

@blag
Copy link
Contributor Author

blag commented Oct 21, 2021

Thanks, cheers! 🍺

sharon2719 pushed a commit to sharon2719/airflow that referenced this pull request Oct 27, 2021
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Apr 11, 2022
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow area:dev-tools area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants