-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup string concatenations #19099
Fixup string concatenations #19099
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Awesome work, congrats on your first merged pull request! |
@blag, congrats on your first commit 🍺 |
Thanks, cheers! 🍺 |
This PR just fixes a few string concatenations here and there. Please pay particular attention to the regexes that I tweaked.
I may have been a little overzealous with my changes, namely:
I also updated the tabulate dependency from 0.8.7 to 0.8.8 to fix an issue when attempting to run unit tests under Python 3.10. Those tests still fail for other reasons but this is one less speed bump when we add that, however, I'm not sure if including that change is appropriate in this PR.