Fix hard-coded /tmp directory in CloudSQL Hook #19229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /tmp directory is not "guaranteed" to be THE /tmp one. There are cases where TMPDIR or other env variables are set to override it (for example when user has no write access to /tmp dir) and we should respect that. The gettempdir() will produce the right temporary directory based on the env variables set in the system.
boring-cyborg
bot
added
area:providers
provider:google
|
Maybe worth creating another pull request for /tmp usage in utils/db.py |
Can you :) ? |
mik-laj
approved these changes
Oct 26, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Oct 26, 2021
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
The /tmp directory is not "guaranteed" to be THE /tmp one. There are cases where TMPDIR or other env variables are set to override it (for example when user has no write access to /tmp dir) and we should respect that. The gettempdir() will produce the right temporary directory based on the env variables set in the system.
aran3
added a commit
to aran3/airflow
that referenced
this pull request
Oct 27, 2021
respecting tempdir enviroment variables. See apache#19208, apache#19229.
potiuk
pushed a commit
that referenced
this pull request
Oct 27, 2021
54 tasks
jedcunningham
pushed a commit
that referenced
this pull request
Nov 3, 2021
This was referenced Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /tmp directory is not "guaranteed" to be THE /tmp one. There
are cases where TMPDIR or other env variables are set to override
it (for example when user has no write access to /tmp dir) and
we should respect that. The gettempdir() will produce the right
temporary directory based on the env variables set in the system.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.