Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Databricks operators to match latest version of API 2.0 #19443

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Nov 6, 2021

This includes:

  • added support for jar_params in the DatabricksRunNowOperator
  • added support for pipeline_task in the DatabricksSubmitRunOperator

Also, added documentation for DatabricksRunNowOperator

closes: #10786

@potiuk potiuk closed this Nov 7, 2021
@potiuk potiuk reopened this Nov 7, 2021
@potiuk
Copy link
Member

potiuk commented Nov 7, 2021

Looked like intermittent problem. Closed/reopened to rebuild

@github-actions
Copy link

github-actions bot commented Nov 7, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 7, 2021
@potiuk
Copy link
Member

potiuk commented Nov 7, 2021

Docs are failing @alexott

@alexott
Copy link
Contributor Author

alexott commented Nov 7, 2021

Thank you @potiuk - I'll fix it. I run pre-commit, but it was failing on pulling the base docker image, or something like, so it looks like i missed the docs part

This includes:
- added support for `jar_params` in the `DatabricksRunNowOperator`
- added support for `pipeline_task` in the `DatabricksSubmitRunOperator`

Also, added documentation for `DatabricksRunNowOperator`

this fixes apache#10786
@alexott alexott force-pushed the databricks-add-new-parameters branch from d175040 to e6bebdf Compare November 7, 2021 17:24
@alexott
Copy link
Contributor Author

alexott commented Nov 7, 2021

Ok, docs are fixed.

@potiuk potiuk merged commit 3a0c455 into apache:main Nov 7, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 7, 2021

Awesome work, congrats on your first merged pull request!

@alexott
Copy link
Contributor Author

alexott commented Nov 7, 2021

Thank you for help Jarek! Next PRs should be simpler, after I got familiar with the workflow & tooling

@alexott alexott deleted the databricks-add-new-parameters branch November 7, 2021 19:14
@potiuk
Copy link
Member

potiuk commented Nov 7, 2021

Cool! Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatabricksRunNowOperator missing jar_params as a kwarg
2 participants