Log exception in local executor #21667
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log.error() call swallows the traceback, making debugging much difficult. This makes the full traceback be logged instead.
boring-cyborg
bot
added
the
area:Scheduler
ashb
approved these changes
Feb 18, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Feb 18, 2022
|
Static check failed (without logs - so I reopened to check if mypy is happy) |
kaxil
approved these changes
Feb 18, 2022
|
Well looks like Mypy is unhappy; I'll revert that line. |
|
Very hard to please that one :D. |
uranusjr
force-pushed
the
local-executor-log-exception
branch
from
56d9846 to
693fecb
Compare
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 16, 2022
(cherry picked from commit a0fb0bb)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 20, 2022
(cherry picked from commit a0fb0bb)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit a0fb0bb)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit a0fb0bb)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit a0fb0bb)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit a0fb0bb)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit a0fb0bb)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 26, 2022
(cherry picked from commit a0fb0bb)
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
log.error()call swallows the traceback, making debugging much difficult. This makes the full traceback be logged instead.The
RuntimeErrormypy hack seems to no longer be needed so I removed it (CI will tell if this is wrong).