-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pandas upper limit now that SQLA is 1.4+ #22162
Conversation
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Hmmm something is still keeping it at pandas v1.3.5. I guess it's still using the constraints from main for this build? |
The "Eager upgrade" builds running when setup.py and setup.cfg change (or run in My bext guess is some of the dependencies in google provider or apache-beam - but this is coming more from intuition and guess. Unfortunately (and @uranusjr might have some other tricks which I am not aware of) it might be not easy guess if this is done through an extra (or even transitive extra as it happens) because The way to check it (at least what I use):
Then run:
Then look for pandas.
What's helpful here is https://pypi.org/pypi/PACKAGE/json and specifically https://pypi.org/pypi/PACKAGE/VERSION/json that can help as it contains the meta-data. But when it comes to extras and transitive extras it's more of a manual effort than automation, I think it's rather dificult to replicate what |
Another option (probably easiest):
Find all packages importing pandas:
Result (short list of candidates to check):
|
Hey @ashb @dstandish @kaxil @jedcunningham - can you please rebase the PR ? I took a deeper look and the reason why pandas is held back is rather straightforward - Pandas 1.4+ does not support Python 3.7 any more 😱 So there is no way it can be upgraded for 3.7. The PR has |
Reopened to rebuild and check for 3.8/3.9 pandas upgrade. |
2276fd4
to
75b44a2
Compare
Yep. As expected. Pandas was upgraded to 1.4 in Python 3.8+ - so it was simply Python 3.7 that still uses old Pandas simply because Pandas 1.4 is Python 3.8+ |
No description provided.