collect sawarning as error in pytest

[BobDu]

Signed-off-by: BobDu i@bobdu.cc

related: #28198 #28544

Improve unit test make sure there isn't a regression in the future.

when delete

airflow/airflow/jobs/scheduler_job.py

Line 1539 in 6dc28fb

.join(DM, TI.dag_id == DM.dag_id)

run pytest tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_find_zombies
while have a error in unit test result

FAILED tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_find_zombies - sqlalchemy.exc.SAWarning: SELECT statement has a cartesian product between FROM element(s) "dag" and FROM element "task_instance".  Apply join condition(s) between each element to...

ref: https://docs.python.org/3/library/warnings.html#the-warnings-filter

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[Taragolis]

@BobDu I think this changes conflicts with pytest-capture-warnings plugin. I check locally and with our current settings and plugins nothing happen, unfortunetly

Without disable pytest-capture-warnings

root@a33668319fad:/opt/airflow# pytest tests/jobs/test_scheduler_job.py::TestSchedulerJob

==================================================================== test session starts ====================================================================
platform linux -- Python 3.7.16, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: cov-4.0.0, asyncio-0.20.3, rerunfailures-9.1.1, instafail-0.4.2, anyio-3.6.2, timeouts-1.2.1, xdist-3.1.0, requests-mock-1.10.0, capture-warnings-0.0.4, httpx-0.21.2, time-machine-2.8.2
asyncio: mode=strict
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 142 items    

...

All Warning errors can be found in the warnings.txt file.

...

============================================================== 139 passed, 3 skipped in 17.45s ==============================================================

Disable pytest-capture-warnings

root@a33668319fad:/opt/airflow# pytest -p no:capture_warnings tests/jobs/test_scheduler_job.py::TestSchedulerJob

==================================================================== test session starts ====================================================================
platform linux -- Python 3.7.16, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: cov-4.0.0, asyncio-0.20.3, rerunfailures-9.1.1, instafail-0.4.2, anyio-3.6.2, timeouts-1.2.1, xdist-3.1.0, requests-mock-1.10.0, httpx-0.21.2, time-machine-2.8.2
asyncio: mode=strict
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 142 items     

...

================================================================== short test summary info ==================================================================
...
FAILED tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_find_zombies_nothing - sqlalchemy.exc.SAWarning: SELECT statement has a cartesian product ...
FAILED tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_find_zombies - sqlalchemy.exc.SAWarning: SELECT statement has a cartesian product between ...
FAILED tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_find_zombies_handle_failure_callbacks_are_correctly_passed_to_dag_processor - sqlalchemy.e...
================================================== 3 failed, 136 passed, 3 skipped, 26 warnings in 18.43s ===================================================

[BobDu]

@BobDu I think this changes conflicts with pytest-capture-warnings plugin. I check locally and with our current settings and plugins nothing happen, unfortunetly

covert to draft and i will explore this.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.