From 7d0fe2665ab549f0cde5cfda704cd46398f13cdc Mon Sep 17 00:00:00 2001 From: EricGao888 Date: Wed, 11 Jan 2023 21:00:25 +0800 Subject: [PATCH 1/2] Fix incorrect comments of worker-kedaautoscaler based on default values in values.yaml --- chart/templates/workers/worker-kedaautoscaler.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/chart/templates/workers/worker-kedaautoscaler.yaml b/chart/templates/workers/worker-kedaautoscaler.yaml index 7fae352f93f6d..d52a53b899675 100644 --- a/chart/templates/workers/worker-kedaautoscaler.yaml +++ b/chart/templates/workers/worker-kedaautoscaler.yaml @@ -37,10 +37,10 @@ spec: scaleTargetRef: kind: {{ ternary "StatefulSet" "Deployment" .Values.workers.persistence.enabled }} name: {{ .Release.Name }}-worker - pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 30 seconds - cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 300 seconds + pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 5 seconds + cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 30 seconds minReplicaCount: {{ .Values.workers.keda.minReplicaCount }} # Optional. Default: 0 - maxReplicaCount: {{ .Values.workers.keda.maxReplicaCount }} # Optional. Default: 100 + maxReplicaCount: {{ .Values.workers.keda.maxReplicaCount }} # Optional. Default: 10 {{- if .Values.workers.keda.advanced }} advanced: {{ toYaml .Values.workers.keda.advanced | indent 4 }} From 598a2f33f53635d1bcae81949f836df43a905c25 Mon Sep 17 00:00:00 2001 From: EricGao888 Date: Thu, 12 Jan 2023 11:47:58 +0800 Subject: [PATCH 2/2] Remove redundant comments to avoid inconsistency --- chart/templates/workers/worker-kedaautoscaler.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/chart/templates/workers/worker-kedaautoscaler.yaml b/chart/templates/workers/worker-kedaautoscaler.yaml index d52a53b899675..2ec0eda166a56 100644 --- a/chart/templates/workers/worker-kedaautoscaler.yaml +++ b/chart/templates/workers/worker-kedaautoscaler.yaml @@ -37,10 +37,10 @@ spec: scaleTargetRef: kind: {{ ternary "StatefulSet" "Deployment" .Values.workers.persistence.enabled }} name: {{ .Release.Name }}-worker - pollingInterval: {{ .Values.workers.keda.pollingInterval }} # Optional. Default: 5 seconds - cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} # Optional. Default: 30 seconds - minReplicaCount: {{ .Values.workers.keda.minReplicaCount }} # Optional. Default: 0 - maxReplicaCount: {{ .Values.workers.keda.maxReplicaCount }} # Optional. Default: 10 + pollingInterval: {{ .Values.workers.keda.pollingInterval }} + cooldownPeriod: {{ .Values.workers.keda.cooldownPeriod }} + minReplicaCount: {{ .Values.workers.keda.minReplicaCount }} + maxReplicaCount: {{ .Values.workers.keda.maxReplicaCount }} {{- if .Values.workers.keda.advanced }} advanced: {{ toYaml .Values.workers.keda.advanced | indent 4 }}