Revert "Refactor Sqlalchemy queries to 2.0 style (Part 3) (#32177)" #32343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 1065687.
potiuk
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
potiuk
added
the
full tests needed
|
We need to revert and later you will have to reapply this one with "full tests needed" as it caused MSSQL failure in main @phanikumv. Sorry for that inconvenience but MSSQL tests are not stable when run on public runners so things like that might happen. We will likely have to find a better way for that one (I have an idea that I will explore soon). |
1 task
|
Until it is somehow mitigated, just "full tests needed" shoudl be applied in cases like this one (sqlalchemy refactor) to test also mssql |
ephraimbuddy
approved these changes
Jul 4, 2023
|
OK. It passed the tests that were failing in main. Merging. |
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1065687.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.