Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min version of sqlparse to 0.5.1 #43961

Closed
wants to merge 1 commit into from
Closed

Bump min version of sqlparse to 0.5.1 #43961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generated/provider_dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@
"deps": [
"apache-airflow>=2.8.0",
"more-itertools>=9.0.0",
"sqlparse>=0.4.2"
"sqlparse>=0.5.1"
Copy link
Member

@potiuk potiuk Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW. @eladkal - don't you think it should come as part of #41916 -> it would be put in context "we bump it because we are using this new feature"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that 5f94f33 was added so we can close this one. Had problems with pushing commit to the author fork

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I like it better too - this one would be linked via comment but not "straightforward" really. If I search with git blame for example, it would show me much more reasoning in the single commit that I'd find, without looking for the "related" one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, good call @potiuk

],
"devel-deps": [],
"plugins": [],
Expand Down
2 changes: 1 addition & 1 deletion providers/src/airflow/providers/common/sql/provider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ versions:

dependencies:
- apache-airflow>=2.8.0
- sqlparse>=0.4.2
- sqlparse>=0.5.1
- more-itertools>=9.0.0

additional-extras:
Expand Down
Loading