From 5047c5b33b5717f62882c45433046b6c19b38465 Mon Sep 17 00:00:00 2001 From: wei-juncheng Date: Mon, 24 Feb 2025 00:18:35 +0800 Subject: [PATCH 1/3] Add extra fields placeholders in Trino connection UI --- .../airflow/providers/trino/hooks/trino.py | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/providers/trino/src/airflow/providers/trino/hooks/trino.py b/providers/trino/src/airflow/providers/trino/hooks/trino.py index befa576d1c64c..1fd9eea0bf501 100644 --- a/providers/trino/src/airflow/providers/trino/hooks/trino.py +++ b/providers/trino/src/airflow/providers/trino/hooks/trino.py @@ -92,6 +92,42 @@ class TrinoHook(DbApiHook): query_id = "" _test_connection_sql = "select 1" + @classmethod + def get_ui_field_behaviour(cls) -> dict[str, Any]: + """Return custom field behaviour.""" + import json + + return { + "hidden_fields": [], + "relabeling": {}, + "placeholders": { + "extra": json.dumps( + { + "auth": "authentication type", + "impersonate_as_owner": "allow impersonate as owner", + "jwt__token": "JWT token", + "jwt__file": "JWT file path", + "certs__client_cert_path": "Client certificate path", + "certs__client_key_path": "Client key path", + "kerberos__config": "Kerberos config", + "kerberos__service_name": "Kerberos service name", + "kerberos__mutual_authentication": "Kerberos mutual authentication", + "kerberos__force_preemptive": "Kerberos force preemptive", + "kerberos__hostname_override": "Kerberos hostname override", + "kerberos__sanitize_mutual_error_response": "Kerberos sanitize mutual error response", + "kerberos__principal": "Kerberos principal", + "kerberos__delegate": "Kerberos delegate", + "kerberos__ca_bundle": "Kerberos CA bundle", + "session_properties": "session properties", + "client_tags": "Trino client tags. Example ['sales','cluster1']", + "timezone": "Trino timezone", + }, + indent=1, + ), + "login": "Effective user for connection", + }, + } + def __init__(self, *args, **kwargs): super().__init__(*args, **kwargs) self._placeholder: str = "?" From 6a56a0d0edaec0c2c2b448171c5ff0be5081b7bb Mon Sep 17 00:00:00 2001 From: wei-juncheng Date: Mon, 24 Feb 2025 15:24:51 +0800 Subject: [PATCH 2/3] remove import --- providers/trino/src/airflow/providers/trino/hooks/trino.py | 1 - 1 file changed, 1 deletion(-) diff --git a/providers/trino/src/airflow/providers/trino/hooks/trino.py b/providers/trino/src/airflow/providers/trino/hooks/trino.py index 1fd9eea0bf501..f2d9898d8c3d1 100644 --- a/providers/trino/src/airflow/providers/trino/hooks/trino.py +++ b/providers/trino/src/airflow/providers/trino/hooks/trino.py @@ -95,7 +95,6 @@ class TrinoHook(DbApiHook): @classmethod def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field behaviour.""" - import json return { "hidden_fields": [], From 2d8d63c6f2e401ae50a56531b12f6ce2f9f720e8 Mon Sep 17 00:00:00 2001 From: wei-juncheng Date: Mon, 24 Feb 2025 17:00:59 +0800 Subject: [PATCH 3/3] fix CI --- providers/trino/src/airflow/providers/trino/hooks/trino.py | 1 - 1 file changed, 1 deletion(-) diff --git a/providers/trino/src/airflow/providers/trino/hooks/trino.py b/providers/trino/src/airflow/providers/trino/hooks/trino.py index f2d9898d8c3d1..c1a5f25bae354 100644 --- a/providers/trino/src/airflow/providers/trino/hooks/trino.py +++ b/providers/trino/src/airflow/providers/trino/hooks/trino.py @@ -95,7 +95,6 @@ class TrinoHook(DbApiHook): @classmethod def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field behaviour.""" - return { "hidden_fields": [], "relabeling": {},