Add response migration for consumed_asset_events events field
#48940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And, like I should have done in apache#48888, add tests this time. The issue was caused by me misunderstanding how Cadwyn works, the `instructions_to_migrate_to_previous_version` only affect the OpenAPI schema, but since the change in this case results in an "invalid" model being returned, we have to write our own migration for the data. For those curious, the error without this migration function is: > fastapi.exceptions.ResponseValidationError: 1 validation errors: > {'type': 'extra_forbidden', 'loc': ('response', 'dag_run', 'consumed_asset_events'), 'msg': 'Extra inputs are not permitted', 'input': []}
Member
Author
|
Spotted by @feluelle |
feluelle
approved these changes
Apr 8, 2025
kaxil
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And, like I should have done in #48888, add tests this time.
The issue was caused by me misunderstanding how Cadwyn works, the
instructions_to_migrate_to_previous_versiononly affect the OpenAPI schema,but since the change in this case results in an "invalid" model being
returned, we have to write our own migration for the data.
For those curious, the error without this migration function is:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.