From 87d34267c0d649a9ca2e2de0646dc056423c2ac8 Mon Sep 17 00:00:00 2001 From: Wei Lee Date: Thu, 10 Apr 2025 18:12:05 +0800 Subject: [PATCH 1/5] docs(newsfragments): check action items that has been done --- .../newsfragments/48066.significant.rst | 56 +++++++++---------- .../newsfragments/48528.significant.rst | 2 +- 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/airflow-core/newsfragments/48066.significant.rst b/airflow-core/newsfragments/48066.significant.rst index 236b04372904d..c0767207321fa 100644 --- a/airflow-core/newsfragments/48066.significant.rst +++ b/airflow-core/newsfragments/48066.significant.rst @@ -48,31 +48,31 @@ The following configuration options are now unused and have been removed: * ``airflow config lint`` - * [ ] Remove configuration option ``[webserver] web_server_master_timeout`` - * [ ] Remove configuration option ``[webserver] worker_refresh_batch_size`` - * [ ] Remove configuration option ``[webserver] worker_refresh_interval`` - * [ ] Remove configuration option ``[webserver] reload_on_plugin_change`` - * [ ] Remove configuration option ``[webserver] worker_class`` - * [ ] Remove configuration option ``[webserver] expose_stacktrace`` - * [ ] Remove configuration option ``[webserver] log_fetch_delay_sec`` - * [ ] Remove configuration option ``[webserver] log_auto_tailing_offset`` - * [ ] Remove configuration option ``[webserver] log_animation_speed`` - * [ ] Remove configuration option ``[webserver] default_dag_run_display_number`` - * [ ] Remove configuration option ``[webserver] enable_proxy_fix`` - * [ ] Remove configuration option ``[webserver] proxy_fix_x_for`` - * [ ] Remove configuration option ``[webserver] proxy_fix_x_proto`` - * [ ] Remove configuration option ``[webserver] proxy_fix_x_host`` - * [ ] Remove configuration option ``[webserver] proxy_fix_x_port`` - * [ ] Remove configuration option ``[webserver] proxy_fix_x_prefix`` - * [ ] Remove configuration option ``[webserver] cookie_secure`` - * [ ] Remove configuration option ``[webserver] analytics_tool`` - * [ ] Remove configuration option ``[webserver] analytics_id`` - * [ ] Remove configuration option ``[webserver] analytics_url`` - * [ ] Remove configuration option ``[webserver] show_recent_stats_for_completed_runs`` - * [ ] Remove configuration option ``[webserver] run_internal_api`` - * [ ] Remove configuration option ``[webserver] caching_hash_method`` - * [ ] Remove configuration option ``[webserver] show_trigger_form_if_no_params`` - * [ ] Remove configuration option ``[webserver] num_recent_configurations_for_trigger`` - * [ ] Remove configuration option ``[webserver] allowed_payload_size`` - * [ ] Remove configuration option ``[webserver] max_form_memory_size`` - * [ ] Remove configuration option ``[webserver] max_form_parts`` + * [x] Remove configuration option ``[webserver] web_server_master_timeout`` + * [x] Remove configuration option ``[webserver] worker_refresh_batch_size`` + * [x] Remove configuration option ``[webserver] worker_refresh_interval`` + * [x] Remove configuration option ``[webserver] reload_on_plugin_change`` + * [x] Remove configuration option ``[webserver] worker_class`` + * [x] Remove configuration option ``[webserver] expose_stacktrace`` + * [x] Remove configuration option ``[webserver] log_fetch_delay_sec`` + * [x] Remove configuration option ``[webserver] log_auto_tailing_offset`` + * [x] Remove configuration option ``[webserver] log_animation_speed`` + * [x] Remove configuration option ``[webserver] default_dag_run_display_number`` + * [x] Remove configuration option ``[webserver] enable_proxy_fix`` + * [x] Remove configuration option ``[webserver] proxy_fix_x_for`` + * [x] Remove configuration option ``[webserver] proxy_fix_x_proto`` + * [x] Remove configuration option ``[webserver] proxy_fix_x_host`` + * [x] Remove configuration option ``[webserver] proxy_fix_x_port`` + * [x] Remove configuration option ``[webserver] proxy_fix_x_prefix`` + * [x] Remove configuration option ``[webserver] cookie_secure`` + * [x] Remove configuration option ``[webserver] analytics_tool`` + * [x] Remove configuration option ``[webserver] analytics_id`` + * [x] Remove configuration option ``[webserver] analytics_url`` + * [x] Remove configuration option ``[webserver] show_recent_stats_for_completed_runs`` + * [x] Remove configuration option ``[webserver] run_internal_api`` + * [x] Remove configuration option ``[webserver] caching_hash_method`` + * [x] Remove configuration option ``[webserver] show_trigger_form_if_no_params`` + * [x] Remove configuration option ``[webserver] num_recent_configurations_for_trigger`` + * [x] Remove configuration option ``[webserver] allowed_payload_size`` + * [x] Remove configuration option ``[webserver] max_form_memory_size`` + * [x] Remove configuration option ``[webserver] max_form_parts`` diff --git a/airflow-core/newsfragments/48528.significant.rst b/airflow-core/newsfragments/48528.significant.rst index d8ae2706f7d6b..252585a6eff3d 100644 --- a/airflow-core/newsfragments/48528.significant.rst +++ b/airflow-core/newsfragments/48528.significant.rst @@ -19,4 +19,4 @@ Users should switch to ``LocalExecutor`` or ``CeleryExecutor`` as alternatives. * ``airflow config lint`` - * [ ] Convert all ``SequentialExecutor`` to ``LocalExecutor`` in ``[core] executor`` + * [x] Convert all ``SequentialExecutor`` to ``LocalExecutor`` in ``[core] executor`` From 5e962581e9df0574f3593e2f6dd271c0bdbb1e20 Mon Sep 17 00:00:00 2001 From: Wei Lee Date: Thu, 10 Apr 2025 18:12:42 +0800 Subject: [PATCH 2/5] feat(config_command): add "core.dag_default_view" and "core.dag_orientation" --- airflow-core/newsfragments/api-38.significant.rst | 4 ++-- airflow-core/src/airflow/cli/commands/config_command.py | 8 ++++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/airflow-core/newsfragments/api-38.significant.rst b/airflow-core/newsfragments/api-38.significant.rst index a805022545f6f..3167475a9aeaa 100644 --- a/airflow-core/newsfragments/api-38.significant.rst +++ b/airflow-core/newsfragments/api-38.significant.rst @@ -20,8 +20,8 @@ * ``airflow config lint`` - * [ ] ``core.dag_default_view`` - * [ ] ``core.dag_orientation`` + * [x] ``core.dag_default_view`` + * [x] ``core.dag_orientation`` * ruff diff --git a/airflow-core/src/airflow/cli/commands/config_command.py b/airflow-core/src/airflow/cli/commands/config_command.py index 1184a50a356ac..b031772d550f3 100644 --- a/airflow-core/src/airflow/cli/commands/config_command.py +++ b/airflow-core/src/airflow/cli/commands/config_command.py @@ -165,6 +165,14 @@ def message(self) -> str | None: suggestion="Dataset URI with a defined scheme will now always be validated strictly, " "raising a hard error on validation failure.", ), + ConfigChange( + config=ConfigParameter("core", "dag_default_view"), + was_deprecated=False, + ), + ConfigChange( + config=ConfigParameter("core", "dag_orientation"), + was_deprecated=False, + ), ConfigChange( config=ConfigParameter("core", "dataset_manager_class"), renamed_to=ConfigParameter("core", "asset_manager_class"), From 4cedcf26a634fddf56b35d0cf9d685d72463380d Mon Sep 17 00:00:00 2001 From: Wei Lee Date: Thu, 10 Apr 2025 18:17:16 +0800 Subject: [PATCH 3/5] docs(newsfragments): fix wrong description in newsfragments/48528.significant.rst reading #48528, it suggest users to use dag.test() instead of replacing the value as dag.test() --- airflow-core/newsfragments/48579.significant.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/airflow-core/newsfragments/48579.significant.rst b/airflow-core/newsfragments/48579.significant.rst index 4961149e02b23..38d5756c289e2 100644 --- a/airflow-core/newsfragments/48579.significant.rst +++ b/airflow-core/newsfragments/48579.significant.rst @@ -19,4 +19,4 @@ Users should switch to ``LocalExecutor`` or ``CeleryExecutor`` as alternatives. * ``airflow config lint`` - * [ ] Convert all ``DebugExecutor`` to ``dag.test()`` when present in ``[core] executor`` + * [ ] Convert all ``DebugExecutor`` to ``LocalExecutor`` when present in ``[core] executor`` From c55919fc653ae34c1eec922007dd1e02b52bc67e Mon Sep 17 00:00:00 2001 From: Wei Lee Date: Thu, 10 Apr 2025 18:27:23 +0800 Subject: [PATCH 4/5] feat(config_command): add scheduler.create_cron_data_intervals and scheduler.create_delta_data_intervals to config lint --- airflow-core/newsfragments/47070.significant.rst | 4 ++-- .../src/airflow/cli/commands/config_command.py | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/airflow-core/newsfragments/47070.significant.rst b/airflow-core/newsfragments/47070.significant.rst index 4cf7b8e7e4c4d..0f38abf16a3b2 100644 --- a/airflow-core/newsfragments/47070.significant.rst +++ b/airflow-core/newsfragments/47070.significant.rst @@ -21,5 +21,5 @@ See :ref:`Differences between "trigger" and "data interval" timetables` for more * ``airflow config lint`` - * [ ] ``scheduler.create_cron_data_intervals`` - * [ ] ``scheduler.create_delta_data_intervals`` + * [x] ``scheduler.create_cron_data_intervals`` (default changed to ``False``) + * [x] ``scheduler.create_delta_data_intervals`` (default changed to ``False``) diff --git a/airflow-core/src/airflow/cli/commands/config_command.py b/airflow-core/src/airflow/cli/commands/config_command.py index b031772d550f3..929da96b3d85e 100644 --- a/airflow-core/src/airflow/cli/commands/config_command.py +++ b/airflow-core/src/airflow/cli/commands/config_command.py @@ -516,6 +516,9 @@ def message(self) -> str | None: ConfigChange( config=ConfigParameter("scheduler", "dependency_detector"), ), + ConfigChange( + config=ConfigParameter("scheduler", "dependency_detector"), + ), ConfigChange( config=ConfigParameter("scheduler", "allow_trigger_in_future"), ), @@ -531,6 +534,18 @@ def message(self) -> str | None: "set this configuration parameter to `True` in the `scheduler` section of your `airflow.cfg` " "to enable the behavior from Airflow 2.x.", ), + ConfigChange( + config=ConfigParameter("scheduler", "create_cron_data_intervals"), + default_change=True, + new_default=False, + was_removed=False, + ), + ConfigChange( + config=ConfigParameter("scheduler", "create_delta_data_intervals"), + default_change=True, + new_default=False, + was_removed=False, + ), ConfigChange( config=ConfigParameter("scheduler", "processor_poll_interval"), renamed_to=ConfigParameter("scheduler", "scheduler_idle_sleep_time"), From 640daa1406ada85474e82d67b99b813d7cd99900 Mon Sep 17 00:00:00 2001 From: Wei Lee Date: Thu, 10 Apr 2025 19:34:31 +0800 Subject: [PATCH 5/5] Revert "feat(config_command): add scheduler.create_cron_data_intervals and scheduler.create_delta_data_intervals to config lint" This reverts commit e60bfe3104f99ca20073d49863f225eea830f2e0. --- airflow-core/newsfragments/47070.significant.rst | 4 ++-- .../src/airflow/cli/commands/config_command.py | 15 --------------- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/airflow-core/newsfragments/47070.significant.rst b/airflow-core/newsfragments/47070.significant.rst index 0f38abf16a3b2..4cf7b8e7e4c4d 100644 --- a/airflow-core/newsfragments/47070.significant.rst +++ b/airflow-core/newsfragments/47070.significant.rst @@ -21,5 +21,5 @@ See :ref:`Differences between "trigger" and "data interval" timetables` for more * ``airflow config lint`` - * [x] ``scheduler.create_cron_data_intervals`` (default changed to ``False``) - * [x] ``scheduler.create_delta_data_intervals`` (default changed to ``False``) + * [ ] ``scheduler.create_cron_data_intervals`` + * [ ] ``scheduler.create_delta_data_intervals`` diff --git a/airflow-core/src/airflow/cli/commands/config_command.py b/airflow-core/src/airflow/cli/commands/config_command.py index 929da96b3d85e..b031772d550f3 100644 --- a/airflow-core/src/airflow/cli/commands/config_command.py +++ b/airflow-core/src/airflow/cli/commands/config_command.py @@ -516,9 +516,6 @@ def message(self) -> str | None: ConfigChange( config=ConfigParameter("scheduler", "dependency_detector"), ), - ConfigChange( - config=ConfigParameter("scheduler", "dependency_detector"), - ), ConfigChange( config=ConfigParameter("scheduler", "allow_trigger_in_future"), ), @@ -534,18 +531,6 @@ def message(self) -> str | None: "set this configuration parameter to `True` in the `scheduler` section of your `airflow.cfg` " "to enable the behavior from Airflow 2.x.", ), - ConfigChange( - config=ConfigParameter("scheduler", "create_cron_data_intervals"), - default_change=True, - new_default=False, - was_removed=False, - ), - ConfigChange( - config=ConfigParameter("scheduler", "create_delta_data_intervals"), - default_change=True, - new_default=False, - was_removed=False, - ), ConfigChange( config=ConfigParameter("scheduler", "processor_poll_interval"), renamed_to=ConfigParameter("scheduler", "scheduler_idle_sleep_time"),