diff --git a/providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_role_and_permission_endpoint.py b/providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_role_and_permission_endpoint.py index 928584da4d278..8672456fb7a46 100644 --- a/providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_role_and_permission_endpoint.py +++ b/providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_role_and_permission_endpoint.py @@ -63,7 +63,7 @@ class TestRoleEndpoint: @pytest.fixture(autouse=True) def setup_attrs(self, configured_app) -> None: self.app = configured_app - self.client = self.app.test_client() # type:ignore + self.client = self.app.test_client() def teardown_method(self): """ diff --git a/providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_user_endpoint.py b/providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_user_endpoint.py index becfaff197829..8ac12eed715b3 100644 --- a/providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_user_endpoint.py +++ b/providers/fab/tests/unit/fab/auth_manager/api_endpoints/test_user_endpoint.py @@ -80,7 +80,7 @@ class TestUserEndpoint: @pytest.fixture(autouse=True) def setup_attrs(self, configured_app) -> None: self.app = configured_app - self.client = self.app.test_client() # type:ignore + self.client = self.app.test_client() self.session = self.app.appbuilder.get_session def teardown_method(self) -> None: diff --git a/providers/fab/tests/unit/fab/auth_manager/schemas/test_role_and_permission_schema.py b/providers/fab/tests/unit/fab/auth_manager/schemas/test_role_and_permission_schema.py index 97891fdedd5df..a6e9dd4d36964 100644 --- a/providers/fab/tests/unit/fab/auth_manager/schemas/test_role_and_permission_schema.py +++ b/providers/fab/tests/unit/fab/auth_manager/schemas/test_role_and_permission_schema.py @@ -34,7 +34,7 @@ class TestRoleCollectionItemSchema: @pytest.fixture(scope="class") def role(self, minimal_app_for_auth_api): yield create_role( - minimal_app_for_auth_api, # type: ignore + minimal_app_for_auth_api, name="Test", permissions=[ (permissions.ACTION_CAN_CREATE, permissions.RESOURCE_CONNECTION), @@ -70,7 +70,7 @@ class TestRoleCollectionSchema: @pytest.fixture(scope="class") def role1(self, minimal_app_for_auth_api): yield create_role( - minimal_app_for_auth_api, # type: ignore + minimal_app_for_auth_api, name="Test1", permissions=[ (permissions.ACTION_CAN_CREATE, permissions.RESOURCE_CONNECTION), @@ -81,7 +81,7 @@ def role1(self, minimal_app_for_auth_api): @pytest.fixture(scope="class") def role2(self, minimal_app_for_auth_api): yield create_role( - minimal_app_for_auth_api, # type: ignore + minimal_app_for_auth_api, name="Test2", permissions=[ (permissions.ACTION_CAN_EDIT, permissions.RESOURCE_DAG), diff --git a/providers/fab/tests/unit/fab/auth_manager/schemas/test_user_schema.py b/providers/fab/tests/unit/fab/auth_manager/schemas/test_user_schema.py index 2afdcb579024f..7b1c06e70177f 100644 --- a/providers/fab/tests/unit/fab/auth_manager/schemas/test_user_schema.py +++ b/providers/fab/tests/unit/fab/auth_manager/schemas/test_user_schema.py @@ -48,14 +48,14 @@ def configured_app(minimal_app_for_auth_api): ) yield app - delete_role(app, "TestRole") # type:ignore + delete_role(app, "TestRole") class TestUserBase: @pytest.fixture(autouse=True) def setup_attrs(self, configured_app) -> None: self.app = configured_app - self.client = self.app.test_client() # type:ignore + self.client = self.app.test_client() self.role = self.app.appbuilder.sm.find_role("TestRole") self.session = self.app.appbuilder.get_session diff --git a/providers/fab/tests/unit/fab/auth_manager/test_security.py b/providers/fab/tests/unit/fab/auth_manager/test_security.py index 6285dff9dc300..ed0780c148f99 100644 --- a/providers/fab/tests/unit/fab/auth_manager/test_security.py +++ b/providers/fab/tests/unit/fab/auth_manager/test_security.py @@ -524,9 +524,7 @@ def test_get_accessible_dag_ids(mock_is_logged_in, app, security_manager, sessio session.add(dag_model) session.commit() - security_manager.sync_perm_for_dag( # type: ignore - dag_id, access_control={role_name: permission_action} - ) + security_manager.sync_perm_for_dag(dag_id, access_control={role_name: permission_action}) assert get_auth_manager().get_authorized_dag_ids(user=user) == {"dag_id"} @@ -558,9 +556,7 @@ def test_dont_get_inaccessible_dag_ids_for_dag_resource_permission( session.add(dag_model) session.commit() - security_manager.sync_perm_for_dag( # type: ignore - dag_id, access_control={role_name: permission_action} - ) + security_manager.sync_perm_for_dag(dag_id, access_control={role_name: permission_action}) assert get_auth_manager().get_authorized_dag_ids(user=user) == set() diff --git a/providers/fab/tests/unit/fab/utils.py b/providers/fab/tests/unit/fab/utils.py index f52b898b8c534..9058445eb365b 100644 --- a/providers/fab/tests/unit/fab/utils.py +++ b/providers/fab/tests/unit/fab/utils.py @@ -242,11 +242,11 @@ def manager() -> Generator[list[_TemplateWithContext], None, None]: def record(sender, template, context, **extra): recorded.append(_TemplateWithContext(template, context)) - flask.template_rendered.connect(record, app) # type: ignore + flask.template_rendered.connect(record, app) try: yield recorded finally: - flask.template_rendered.disconnect(record, app) # type: ignore + flask.template_rendered.disconnect(record, app) assert recorded, "Failed to catch the templates" diff --git a/providers/fab/tests/unit/fab/www/views/test_views_custom_user_views.py b/providers/fab/tests/unit/fab/www/views/test_views_custom_user_views.py index 0e4d8faa25a45..cd018f2c10991 100644 --- a/providers/fab/tests/unit/fab/www/views/test_views_custom_user_views.py +++ b/providers/fab/tests/unit/fab/www/views/test_views_custom_user_views.py @@ -88,7 +88,7 @@ def setup_method(self): self.delete_roles() self.db = SQLA(self.app) - self.client = self.app.test_client() # type:ignore + self.client = self.app.test_client() def teardown_method(self): delete_user(self.app, "no_access")