From 173b190a98d44440102087a74d1964eede99ae4a Mon Sep 17 00:00:00 2001 From: Tzu-ping Chung Date: Fri, 29 Aug 2025 15:36:30 +0800 Subject: [PATCH] Use 'orient' kwarg in SalesforceHook Mypy started complaining about this somehow. This should be completely backward compatible. --- .../src/airflow/providers/salesforce/hooks/salesforce.py | 4 ++-- .../tests/unit/salesforce/hooks/test_salesforce.py | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py b/providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py index 14a8e64113fe2..9368cd40c5bbe 100644 --- a/providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py +++ b/providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py @@ -343,9 +343,9 @@ def write_object_to_file( # write the dataframe df.to_csv(filename, index=False) elif fmt == "json": - df.to_json(filename, "records", date_unit="s") + df.to_json(filename, orient="records", date_unit="s") elif fmt == "ndjson": - df.to_json(filename, "records", lines=True, date_unit="s") + df.to_json(filename, orient="records", lines=True, date_unit="s") return df diff --git a/providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py b/providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py index ea96aa02bb180..9cb33157aee47 100644 --- a/providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py +++ b/providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py @@ -377,7 +377,9 @@ def test_write_object_to_file_json_with_timestamp_conversion(self, mock_data_fra ) mock_describe_object.assert_called_once_with(obj_name) - mock_data_frame.return_value.to_json.assert_called_once_with(filename, "records", date_unit="s") + mock_data_frame.return_value.to_json.assert_called_once_with( + filename, orient="records", date_unit="s" + ) pd.testing.assert_frame_equal( data_frame, pd.DataFrame({"test": [1, 2, 3], "field_1": [1.546301e09, 1.546387e09, 1.546474e09]}) ) @@ -396,7 +398,7 @@ def test_write_object_to_file_ndjson_with_record_time(self, mock_data_frame, moc ) mock_data_frame.return_value.to_json.assert_called_once_with( - filename, "records", lines=True, date_unit="s" + filename, orient="records", lines=True, date_unit="s" ) pd.testing.assert_frame_equal( data_frame,