From 52e673df308e016f8e92d75bc5cb42f4aad11c6c Mon Sep 17 00:00:00 2001 From: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Date: Sun, 2 Nov 2025 02:20:12 +0800 Subject: [PATCH] [v3-1-test] Support PR number with use-airflow-version in Breeze (#57667) * Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add tests for PR number pattern matching Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Move PR_NUMBER_PATTERN to global_constants for consistency Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add error handling for deleted fork repositories Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Refactor: consolidate PR number and repo:branch logic in find_installation_spec Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Remove unused get_repo_and_branch_from_pr function Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Support use-airflow-version with PR num for Breeze Add PR number support to --use-airflow-version option Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add tests for PR number pattern matching Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Move PR_NUMBER_PATTERN to global_constants for consistency Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> Add error handling for deleted fork repositories Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com> * Remove not used github utils --------- (cherry picked from commit 19809dd4621499967b7a0c56ca03050f4911da65) Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> --- dev/breeze/doc/images/output-commands.svg | 4 +- ...agement_install-provider-distributions.svg | 66 ++++++------ ...agement_install-provider-distributions.txt | 2 +- ...nagement_verify-provider-distributions.svg | 48 +++++---- ...nagement_verify-provider-distributions.txt | 2 +- dev/breeze/doc/images/output_shell.svg | 100 +++++++++--------- dev/breeze/doc/images/output_shell.txt | 2 +- .../doc/images/output_start-airflow.svg | 76 ++++++------- .../doc/images/output_start-airflow.txt | 2 +- .../doc/images/output_testing_core-tests.svg | 48 +++++---- .../doc/images/output_testing_core-tests.txt | 2 +- .../images/output_testing_providers-tests.svg | 66 ++++++------ .../images/output_testing_providers-tests.txt | 2 +- .../images/output_testing_system-tests.svg | 48 +++++---- .../images/output_testing_system-tests.txt | 2 +- .../airflow_breeze/commands/common_options.py | 5 +- .../src/airflow_breeze/global_constants.py | 1 + .../utils/custom_param_types.py | 7 +- dev/breeze/tests/test_use_airflow_version.py | 54 ++++++++++ .../install_airflow_and_providers.py | 93 ++++++++++++++-- 20 files changed, 397 insertions(+), 233 deletions(-) create mode 100644 dev/breeze/tests/test_use_airflow_version.py diff --git a/dev/breeze/doc/images/output-commands.svg b/dev/breeze/doc/images/output-commands.svg index 4df859dfffe88..857b530a7d954 100644 --- a/dev/breeze/doc/images/output-commands.svg +++ b/dev/breeze/doc/images/output-commands.svg @@ -341,8 +341,8 @@ │kafka | kerberos | keycloak | localstack | mongo |     │ │mssql | openlineage | otel | pinot | qdrant | redis |  │ │redis | statsd | tinkerpop | trino | ydb)              │ -│--standalone-dag-processor/--no-standalone-dag-process…Run standalone dag processor for start-airflow         │ -│(required for Airflow 3).                              │ +│--standalone-dag-processor/--no-standalone-dag-processoRun standalone dag processor for start-airflow         │ +│r(required for Airflow 3).                              │ │[default: standalone-dag-processor]                    │ │--auth-managerSpecify the auth manager to set       │ │(>SimpleAuthManager< | FabAuthManager)│ diff --git a/dev/breeze/doc/images/output_release-management_install-provider-distributions.svg b/dev/breeze/doc/images/output_release-management_install-provider-distributions.svg index 6055d2f2bf481..8c387c5fe34ab 100644 --- a/dev/breeze/doc/images/output_release-management_install-provider-distributions.svg +++ b/dev/breeze/doc/images/output_release-management_install-provider-distributions.svg @@ -1,4 +1,4 @@ - + │--providers-skip-constraintsDo not use constraints when installing providers.│ │--use-airflow-versionUse (reinstall at entry) Airflow version from PyPI. It  │ │can also be version (to install from PyPI), `none`,     │ -│`wheel`, or `sdist` to install from `dist` folder or    │ -│`owner/repo:branch` to install from GitHub repo. Uses   │ -│--mount-sources `remove` if not specified, but          │ -│`providers-and-tests` or `tests` can be specified for   │ -│`--mount-sources` when `--use-airflow-version` is used. │ -│(none | wheel | sdist | <airflow_version> |             │ -│<owner/repo:branch>)                                    │ -│--allow-pre-releasesAllow pre-releases of Airflow, task-sdk, providers and  │ -│airflowctl to be installed. Set to true automatically   │ -│for pre-release --use-airflow-version)                  │ -│--use-distributions-from-distInstall all found distributions (--distribution-format│ -│determines type) from 'dist' folder when entering       │ -│breeze.                                                 │ -╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ -╭─ Parallel running ───────────────────────────────────────────────────────────────────────────────────────────────────╮ -│--run-in-parallelRun the operation in parallel on all or selected subset of parameters.│ -│--parallelismMaximum number of processes to use while running the operation in parallel.│ -│(INTEGER RANGE)                                                            │ -│[default: 4; 1<=x<=8]                                                      │ -│--skip-cleanupSkip cleanup of temporary files created during parallel run.│ -│--include-success-outputsWhether to include outputs of successful runs (not shown by default).│ -│--debug-resourcesWhether to show resource information while running in parallel.│ -╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ -╭─ Common options ─────────────────────────────────────────────────────────────────────────────────────────────────────╮ -│--dry-run-DIf dry-run is set, commands are only printed, not executed.│ -│--verbose-vPrint verbose information about performed steps.│ -│--help-hShow this message and exit.│ -╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ +│`wheel`, or `sdist` to install from `dist` folder,      │ +│`owner/repo:branch` to install from GitHub repo, or a PR│ +│number (e.g., `57219`) to install from a pull request.  │ +│Uses --mount-sources `remove` if not specified, but     │ +│`providers-and-tests` or `tests` can be specified for   │ +│`--mount-sources` when `--use-airflow-version` is used. │ +│(none | wheel | sdist | <airflow_version> |             │ +│<owner/repo:branch> | <pr_number>)                      │ +│--allow-pre-releasesAllow pre-releases of Airflow, task-sdk, providers and  │ +│airflowctl to be installed. Set to true automatically   │ +│for pre-release --use-airflow-version)                  │ +│--use-distributions-from-distInstall all found distributions (--distribution-format│ +│determines type) from 'dist' folder when entering       │ +│breeze.                                                 │ +╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ +╭─ Parallel running ───────────────────────────────────────────────────────────────────────────────────────────────────╮ +│--run-in-parallelRun the operation in parallel on all or selected subset of parameters.│ +│--parallelismMaximum number of processes to use while running the operation in parallel.│ +│(INTEGER RANGE)                                                            │ +│[default: 4; 1<=x<=8]                                                      │ +│--skip-cleanupSkip cleanup of temporary files created during parallel run.│ +│--include-success-outputsWhether to include outputs of successful runs (not shown by default).│ +│--debug-resourcesWhether to show resource information while running in parallel.│ +╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ +╭─ Common options ─────────────────────────────────────────────────────────────────────────────────────────────────────╮ +│--dry-run-DIf dry-run is set, commands are only printed, not executed.│ +│--verbose-vPrint verbose information about performed steps.│ +│--help-hShow this message and exit.│ +╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ diff --git a/dev/breeze/doc/images/output_release-management_install-provider-distributions.txt b/dev/breeze/doc/images/output_release-management_install-provider-distributions.txt index bf517fd018dc5..115486a71b0f1 100644 --- a/dev/breeze/doc/images/output_release-management_install-provider-distributions.txt +++ b/dev/breeze/doc/images/output_release-management_install-provider-distributions.txt @@ -1 +1 @@ -93483a78f7d962f62c879522122c52bc +e31d22e941acae5a95654f82a4c08b4d diff --git a/dev/breeze/doc/images/output_release-management_verify-provider-distributions.svg b/dev/breeze/doc/images/output_release-management_verify-provider-distributions.svg index 2ae4f9d84cf11..92b38df044f0b 100644 --- a/dev/breeze/doc/images/output_release-management_verify-provider-distributions.svg +++ b/dev/breeze/doc/images/output_release-management_verify-provider-distributions.svg @@ -1,4 +1,4 @@ - +