From 869208677c3e7adcfd93592ce6321e9e0885424a Mon Sep 17 00:00:00 2001 From: Kunal Bhattacharya Date: Sun, 7 Dec 2025 13:17:53 +0530 Subject: [PATCH 1/3] Breeze exit on incompatible arguments --- dev/breeze/doc/images/output_start-airflow.svg | 2 +- dev/breeze/doc/images/output_start-airflow.txt | 2 +- .../src/airflow_breeze/commands/developer_commands.py | 10 +++++++++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/dev/breeze/doc/images/output_start-airflow.svg b/dev/breeze/doc/images/output_start-airflow.svg index ce6e35c4ad70e..a1ee0a3da907a 100644 --- a/dev/breeze/doc/images/output_start-airflow.svg +++ b/dev/breeze/doc/images/output_start-airflow.svg @@ -586,7 +586,7 @@ │--skip-assets-compilationSkips compilation of assets when starting airflow even if the content of www changed   │ │(mutually exclusive with --dev-mode).                                                  │ │--dev-modeStarts api-server in dev mode (assets are always recompiled in this case when starting)│ -│(mutually exclusive with --skip-assets-compilation).                                   │ +│(mutually exclusive with --skip-assets-compilation and --use-airflow-version).         │ ╰──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ ╭─ Build CI image (before entering shell) ─────────────────────────────────────────────────────────────────────────────╮ │--force-buildForce image build no matter if it is determined as needed.│ diff --git a/dev/breeze/doc/images/output_start-airflow.txt b/dev/breeze/doc/images/output_start-airflow.txt index c9e59c6f98b80..bad5b95880e1a 100644 --- a/dev/breeze/doc/images/output_start-airflow.txt +++ b/dev/breeze/doc/images/output_start-airflow.txt @@ -1 +1 @@ -5c6ac03e89ec4f0f0137ab4678fae14a +57e1c5585523e7fcf7c3e80527cb34f9 diff --git a/dev/breeze/src/airflow_breeze/commands/developer_commands.py b/dev/breeze/src/airflow_breeze/commands/developer_commands.py index f63fae417d5bb..c0a7196c9ce5d 100644 --- a/dev/breeze/src/airflow_breeze/commands/developer_commands.py +++ b/dev/breeze/src/airflow_breeze/commands/developer_commands.py @@ -515,7 +515,7 @@ def shell( @click.option( "--dev-mode", help="Starts api-server in dev mode (assets are always recompiled in this case when starting) " - "(mutually exclusive with --skip-assets-compilation).", + "(mutually exclusive with --skip-assets-compilation and --use-airflow-version).", is_flag=True, ) @click.option( @@ -628,6 +628,14 @@ def start_airflow( ) skip_assets_compilation = True + if dev_mode and use_airflow_version: + get_console().print( + "[Error][bold red] You cannot set Airflow version in dev mode! Consider switching to the respective" + "version branch if you need to use --dev-mode on a different Airflow version! \nExiting!!" + ) + + sys.exit(1) + # Automatically enable file polling for hot reloading under WSL if dev_mode and is_wsl(): os.environ["CHOKIDAR_USEPOLLING"] = "true" From 12c2a9443235baeee84ab6b5dc868644b53b7e91 Mon Sep 17 00:00:00 2001 From: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Date: Sun, 7 Dec 2025 12:07:19 +0100 Subject: [PATCH 2/3] Apply suggestion from @choo121600 Co-authored-by: Yeonguk Choo --- dev/breeze/src/airflow_breeze/commands/developer_commands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/breeze/src/airflow_breeze/commands/developer_commands.py b/dev/breeze/src/airflow_breeze/commands/developer_commands.py index c0a7196c9ce5d..ffd3d08600ba4 100644 --- a/dev/breeze/src/airflow_breeze/commands/developer_commands.py +++ b/dev/breeze/src/airflow_breeze/commands/developer_commands.py @@ -630,7 +630,7 @@ def start_airflow( if dev_mode and use_airflow_version: get_console().print( - "[Error][bold red] You cannot set Airflow version in dev mode! Consider switching to the respective" + "[error]You cannot set Airflow version in dev mode! Consider switching to the respective" "version branch if you need to use --dev-mode on a different Airflow version! \nExiting!!" ) From 4ff3c3bf86e42f48d8fa0d5b89bce65c4aa45579 Mon Sep 17 00:00:00 2001 From: Kunal Bhattacharya Date: Sun, 7 Dec 2025 16:38:19 +0530 Subject: [PATCH 3/3] Nit fix --- dev/breeze/src/airflow_breeze/commands/developer_commands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/breeze/src/airflow_breeze/commands/developer_commands.py b/dev/breeze/src/airflow_breeze/commands/developer_commands.py index c0a7196c9ce5d..80f87792cc52b 100644 --- a/dev/breeze/src/airflow_breeze/commands/developer_commands.py +++ b/dev/breeze/src/airflow_breeze/commands/developer_commands.py @@ -630,7 +630,7 @@ def start_airflow( if dev_mode and use_airflow_version: get_console().print( - "[Error][bold red] You cannot set Airflow version in dev mode! Consider switching to the respective" + "[error]You cannot set Airflow version in dev mode! Consider switching to the respective " "version branch if you need to use --dev-mode on a different Airflow version! \nExiting!!" )