-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breeze / KinD - support earlier k8s versions, fix recreate and kubectl versioning #9905
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we also probably want is to run the tests on those different versions of kubernetes. Would you mind also extending matrix of the kubernetes versions in .github/workflows/ci.yml for Kubernetes tests?
Hi @potiuk, added the changes yesterday, let me know if there's anything else missing |
Fantastic! Thanks @bbenzikry |
Awesome work, congrats on your first merged pull request! |
cc: @kaxil @dimberman - we have now three versions of Kubernetes tested. I am cherry-picking all the changes to 1.10 now. |
…l versioning (apache#9905) (cherry picked from commit 24a951e)
This PR covers several small issues;
which is an issue for many projects in 1.18 due to Extended CRD Validation kubernetes/kubernetes#88076
A few reference issues:
CRDs don't pass validation on k8s 1.18 kubeflow/spark-operator#921
CustomResourceDefinition is invalid at kubernetes 1.18 operator-framework/operator-sdk#3235
Default value not allowed for in x-kubernetes-list-map-keys kubernetes-sigs/controller-tools#444
I've added the latest versions from kind ( v1.17.5, v1.16.9 ) and updated the default version to v1.18.6
breeze kind-cluster recreate
did not seem to work even though it's mentioned in the breeze docs.Currently throws:
breeze kind-cluster deploy
had a typo in perform_kind_cluster_operationkind-cluster kubectl version ignored KUBERNETES_VERSION ( typo )
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.