Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breeze / KinD - support earlier k8s versions, fix recreate and kubectl versioning #9905

Merged
merged 6 commits into from
Jul 22, 2020

Conversation

bbenzikry
Copy link
Contributor

This PR covers several small issues;

I've added the latest versions from kind ( v1.17.5, v1.16.9 ) and updated the default version to v1.18.6

  • breeze kind-cluster recreate did not seem to work even though it's mentioned in the breeze docs.

    Currently throws:
ERROR: Unknown Kind Kubernetes cluster operation: 'recreate'
Should be one of:
start stop restart status deploy test shell
  • breeze kind-cluster deploy had a typo in perform_kind_cluster_operation

  • kind-cluster kubectl version ignored KUBERNETES_VERSION ( typo )


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 21, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we also probably want is to run the tests on those different versions of kubernetes. Would you mind also extending matrix of the kubernetes versions in .github/workflows/ci.yml for Kubernetes tests?

@bbenzikry bbenzikry requested a review from potiuk July 21, 2020 06:07
@bbenzikry
Copy link
Contributor Author

Hi @potiuk, added the changes yesterday, let me know if there's anything else missing

@potiuk
Copy link
Member

potiuk commented Jul 22, 2020

Fantastic! Thanks @bbenzikry

@potiuk potiuk merged commit 24a951e into apache:master Jul 22, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 22, 2020

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Jul 22, 2020

cc: @kaxil @dimberman - we have now three versions of Kubernetes tested. I am cherry-picking all the changes to 1.10 now.

@potiuk potiuk added this to the Airflow 1.10.12 milestone Jul 22, 2020
potiuk pushed a commit that referenced this pull request Jul 22, 2020
kaxil pushed a commit that referenced this pull request Aug 11, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants