Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Using the parameters in TableConfiguration instead of from Table properties #1943

Closed
3 tasks done
Tracked by #1930
wangtaohz opened this issue Sep 8, 2023 · 0 comments · Fixed by #1944
Closed
3 tasks done
Tracked by #1930

[Improvement]: Using the parameters in TableConfiguration instead of from Table properties #1943

wangtaohz opened this issue Sep 8, 2023 · 0 comments · Fixed by #1944
Labels
type:improvement

Comments

@wangtaohz
Copy link
Contributor

wangtaohz commented Sep 8, 2023 •
edited
Loading

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

We have introduced a class TableConfiguration to keep the table properties.
However, some features do not use this class and instead parse repeatedly from table properties, which is not standardized enough, like expiring snapshots and cleaning orphan files.

How should we improve?

Using TableConfiguration for expiring snapshots and cleaning orphan files.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AMORO-1943] using TableConfiguration instead of TableProperties for AMS wangtaohz/amoro
1 participant
@wangtaohz