Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Improve the triggering conditions for segment file rewriting #1953

Closed
3 tasks done
Tracked by #1930
zhongqishang opened this issue Sep 12, 2023 · 0 comments · Fixed by #1954
Closed
3 tasks done
Tracked by #1930

[Improvement]: Improve the triggering conditions for segment file rewriting #1953

zhongqishang opened this issue Sep 12, 2023 · 0 comments · Fixed by #1954
Labels
type:improvement

Comments

@zhongqishang
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

When the table is relatively large and the committed file is a segment-sized file, a large number of file rewrites will be triggered frequently, requiring a large amount of optimizer resources.

Current trigger condition : getRecordCount(deletes) > dataFile.recordCount() * config.getMajorDuplicateRatio().

How should we improve?

Trigger condition only calculate pos deletes record count.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AMORO-1953][AMS] Improve the triggering conditions for segment file rewriting zhongqishang/amoro
1 participant
@zhongqishang