Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-1953][AMS] Improve the triggering conditions for segment file rewriting #1954

Merged
merged 4 commits into from
Sep 12, 2023
Merged

[AMORO-1953][AMS] Improve the triggering conditions for segment file rewriting #1954

merged 4 commits into from
Sep 12, 2023

Conversation

zhongqishang
Copy link
Contributor

Why are the changes needed?

Close #1953.

Brief change log

  • Improve segment file rewrite trigger conditions.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
...rver/optimizing/plan/CommonPartitionEvaluator.java 100.00%

📢 Thoughts on this report? Let us know!.

wangtaohz
wangtaohz approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@wangtaohz wangtaohz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! 👍 LGTM.

The MixedHivePartitionEvaluator overrides the method fileShouldRewrite of CommonPartitionEvaluator, but it doesn't need to be modified.

@zhoujinsong zhoujinsong merged commit 74504c2 into apache:master Sep 12, 2023
6 checks passed
@zhongqishang zhongqishang deleted the AMORO-1953 branch September 13, 2023 05:57
@zhoujinsong zhoujinsong mentioned this pull request Nov 1, 2023
Closed
3 tasks
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
@zhongqishang @ShawHee
[AMORO-1953][AMS] Improve the triggering conditions for segment file …
bd8eef9 
…rewriting (apache#1954)

* [AMORO-1953][AMS] Improve the triggering conditions for segment file rewriting

* [AMORO-1953][AMS] Fix test error

* [AMORO-1953][AMS] Add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong left review comments

@wangtaohz wangtaohz wangtaohz approved these changes

@shidayang shidayang shidayang approved these changes

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Improve the triggering conditions for segment file rewriting
4 participants
@zhongqishang @zhoujinsong @shidayang @wangtaohz