[AMORO-1906]Refactor code of "Table" and "Catalog" to support Paimon format integration #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:core
…copy # Conflicts: # ams/server/src/main/java/com/netease/arctic/server/table/executor/OrphanFilesCleaningExecutor.java # ams/server/src/main/java/com/netease/arctic/server/table/executor/SnapshotsExpiringExecutor.java # ams/server/src/test/java/com/netease/arctic/server/table/executor/TestSnapshotExpire.java
baiyangtx
reviewed
Sep 13, 2023
ams/server/src/main/java/com/netease/arctic/server/catalog/InternalIcebergCatalogImpl.java
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/dashboard/ServerTableDescriptor.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/optimizing/OptimizingQueue.java
Show resolved
Hide resolved
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/table/DefaultTableService.java
Outdated
Show resolved
Hide resolved
3 tasks
shidayang
changed the title
… paimon-integration-copy
… paimon-integration-copy
HuangFru
reviewed
Sep 18, 2023
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Show resolved
Hide resolved
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Show resolved
Hide resolved
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Show resolved
Hide resolved
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Show resolved
Hide resolved
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Show resolved
Hide resolved
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Outdated
Show resolved
Hide resolved
…copy # Conflicts: # ams/server/src/main/java/com/netease/arctic/server/table/executor/OrphanFilesCleaningExecutor.java
…copy # Conflicts: # ams/server/src/main/java/com/netease/arctic/server/catalog/MixedIcebergCatalogImpl.java # ams/server/src/main/java/com/netease/arctic/server/dashboard/ServerTableDescriptor.java # ams/server/src/main/java/com/netease/arctic/server/table/executor/OrphanFilesCleaningExecutor.java # ams/server/src/main/java/com/netease/arctic/server/table/executor/SnapshotsExpiringExecutor.java # ams/server/src/main/java/com/netease/arctic/server/table/executor/TableRuntimeRefreshExecutor.java # core/src/main/java/com/netease/arctic/formats/mixed/MixedHiveTable.java
zhoujinsong
reviewed
Sep 21, 2023
core/src/main/java/com/netease/arctic/AlreadyExistsException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/DatabaseNotEmptyException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/NoSuchTableException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/formats/iceberg/IcebergSnapshot.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/formats/iceberg/IcebergSnapshot.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/formats/iceberg/IcebergTable.java
Outdated
Show resolved
Hide resolved
zhoujinsong
reviewed
Sep 25, 2023
core/src/main/java/com/netease/arctic/formats/paimon/PaimonCatalogFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/formats/paimon/PaimonCatalogFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/formats/paimon/PaimonCatalogFactory.java
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/dashboard/FormatTableDescriptor.java
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/dashboard/ServerTableDescriptor.java
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/TableMaintainer.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/catalog/PaimonServerCatalog.java
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/dashboard/PaimonTableDescriptor.java
Show resolved
Hide resolved
zhoujinsong
reviewed
Oct 9, 2023
ams/server/src/main/java/com/netease/arctic/server/dashboard/FormatTableDescriptor.java
Outdated
Show resolved
Hide resolved
...server/src/main/java/com/netease/arctic/server/dashboard/MixedAndIcebergTableDescriptor.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/dashboard/PaimonTableDescriptor.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/TableMaintainer.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/TableMaintainer.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Show resolved
Hide resolved
| @@ -80,7 +47,10 @@ protected long getNextExecutingTime(TableRuntime tableRuntime) { | |||
|
|
|||
| @Override | |||
| protected boolean enabled(TableRuntime tableRuntime) { | |||
| return tableRuntime.getTableConfiguration().isExpireSnapshotEnabled(); | |||
| return tableRuntime.getFormat() == TableFormat.ICEBERG && | |||
There was a problem hiding this comment.
Does all the Paimon format tables not require services provided by TableExecutor? If so, can we move the filter logic at a higher level?
There was a problem hiding this comment.
Executor is a fundamental mechanism, and it's difficult to guarantee that Paimon won't use it in the future
core/src/test/java/com/netease/arctic/formats/IcebergCatalogTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/formats/paimon/PaimonCatalogFactory.java
Outdated
Show resolved
Hide resolved
…ixedAndIcebergTableDescriptor.java Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
…aimonTableDescriptor.java Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
zhoujinsong
approved these changes
Oct 10, 2023
3 tasks
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…format integration (apache#1960) * Integration paimon * Integration paimon * Integration paimon * Integration paimon * tmp * Support registering for the Paimon Catalog * Support registering for the Paimon Catalog * Support registering for the Paimon Catalog * Support registering for the Paimon Catalog * Fix ut * Polish code * Fix compile error * Merge master * polish code * Merge master * Fix UT * Polish code * Polish code * polish code * polish code * Update ams/server/src/main/java/com/netease/arctic/server/dashboard/MixedAndIcebergTableDescriptor.java Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com> * Update ams/server/src/main/java/com/netease/arctic/server/dashboard/PaimonTableDescriptor.java Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com> * tmp * polish code * polish code --------- Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #1906.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation