Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1907]Correct and supplement documentation #1995

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

zhoujinsong
Copy link
Contributor

@zhoujinsong zhoujinsong commented Sep 18, 2023

Why are the changes needed?

As #1907 descripted, we should add some tips in the document to help users better utilize the resources of Flink Optimizer.
Besides, this PR supplement upgrade steps for AMS in document.

Brief change log

  • Add Upgrade AMS chapter in deployment.md.
  • Add some flink configuration about flink optimizer.
  • Fix some spelling errors.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Sep 18, 2023
@zhoujinsong zhoujinsong changed the title [Improvement]Correct and supplement documentation [AMORO-1907]Correct and supplement documentation Sep 19, 2023
Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujinsong zhoujinsong merged commit be7294d into apache:master Sep 19, 2023
1 check passed
@zhoujinsong zhoujinsong deleted the modify-docs branch September 19, 2023 11:30
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
* Modify docs for version 0.5.1

* fix some spelling errors

* fix flink optimizer group configuration error

* fix some spelling error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants