Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] specify options various is class field;use ThreadLocal remove instead of set null #2143

Merged
merged 4 commits into from
Oct 19, 2023
Merged

[fix] specify options various is class field;use ThreadLocal remove instead of set null #2143

merged 4 commits into from
Oct 19, 2023

Conversation

GOODBOY008
Copy link
Member

  • specify options various is class field
  • use ThreadLocal method remove instead of set null

@github-actions github-actions bot added module:core Core module module:mixed-trino trino module for Mixed Format module:ams-dashboard Ams dashboard module labels Oct 18, 2023
@GOODBOY008
Copy link
Member Author

@zhoujinsong @shidayang PTAL

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...se/arctic/server/persistence/NestedSqlSession.java 89.47% <100.00%> (ø)
...tease/arctic/server/table/DefaultTableService.java 86.90% <0.00%> (+0.27%) ⬆️
...m/netease/arctic/io/reader/ArcticDeleteFilter.java 74.38% <0.00%> (ø)
...netease/arctic/optimizing/BaseOptimizingInput.java 50.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@GOODBOY008 GOODBOY008 requested a review from shidayang October 19, 2023 03:52
wangtaohz
wangtaohz reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution! 👍

I left some comments, please take a look @GOODBOY008

ams/server/src/main/java/com/netease/arctic/server/table/DefaultTableService.java Outdated Show resolved Hide resolved
core/src/main/java/com/netease/arctic/optimizing/BaseOptimizingInput.java Show resolved Hide resolved
trino/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java Outdated Show resolved Hide resolved
trino/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the module:mixed-trino trino module for Mixed Format label Oct 19, 2023
@shidayang
Copy link
Contributor

LGTM

wangtaohz
wangtaohz approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangtaohz wangtaohz merged commit 27bbc69 into apache:master Oct 19, 2023
5 of 6 checks passed
@wangtaohz wangtaohz mentioned this pull request Oct 19, 2023
Closed
3 tasks
@shidayang shidayang mentioned this pull request Oct 24, 2023
Closed
70 tasks
@GOODBOY008 GOODBOY008 deleted the master-bug branch October 24, 2023 06:21
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
@GOODBOY008 @ShawHee
[fix] specify options various is class field;use ThreadLocal remove i…
3f786c7 
…nstead of set null (apache#2143)

* [fix] specify options various is class field;use ThreadLocal remove instead of set null

* [Bug] Fix NPE when throw ObjectNotExistsException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangtaohz wangtaohz wangtaohz approved these changes

@shidayang shidayang shidayang approved these changes

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module module:core Core module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GOODBOY008 @shidayang @wangtaohz