-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2296] Add cache for loading tables in core and trino #2298
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2298 +/- ##
============================================
- Coverage 52.68% 52.66% -0.02%
+ Complexity 4208 4207 -1
============================================
Files 511 511
Lines 29263 29274 +11
Branches 2860 2862 +2
============================================
Hits 15418 15418
- Misses 12592 12598 +6
- Partials 1253 1258 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
trino/src/main/java/com/netease/arctic/trino/ArcticConnectorMetadata.java
Show resolved
Hide resolved
# Conflicts: # core/src/main/java/com/netease/arctic/mixed/BasicMixedIcebergCatalog.java
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why are the changes needed?
Close #2296.
Brief change log
BasicMixedIcebergCatalog
.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation