Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2296] Add cache for loading tables in core and trino #2298

Merged
merged 8 commits into from
Nov 23, 2023

Conversation

HuangFru
Copy link
Contributor

@HuangFru HuangFru commented Nov 13, 2023

Why are the changes needed?

Close #2296.

Brief change log

  • Add a cache for loading tables.
  • Implement caching catalog in BasicMixedIcebergCatalog.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the module:mixed-trino trino module for Mixed Format label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (a87a2a9) 52.68% compared to head (611c4de) 52.66%.
Report is 11 commits behind head on master.

Files Patch % Lines
.../netease/arctic/trino/unkeyed/IcebergMetadata.java 70.00% 9 Missing ⚠️
...netease/arctic/mixed/BasicMixedIcebergCatalog.java 64.70% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2298      +/-   ##
============================================
- Coverage     52.68%   52.66%   -0.02%     
+ Complexity     4208     4207       -1     
============================================
  Files           511      511              
  Lines         29263    29274      +11     
  Branches       2860     2862       +2     
============================================
  Hits          15418    15418              
- Misses        12592    12598       +6     
- Partials       1253     1258       +5     
Flag Coverage Δ
core 52.95% <64.70%> (-0.02%) ⬇️
trino 51.20% <72.72%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HuangFru HuangFru marked this pull request as draft November 14, 2023 06:46
@github-actions github-actions bot added the module:core Core module label Nov 14, 2023
@HuangFru HuangFru marked this pull request as ready for review November 14, 2023 08:24
@HuangFru HuangFru marked this pull request as draft November 14, 2023 08:26
@HuangFru HuangFru marked this pull request as ready for review November 14, 2023 09:11
# Conflicts:
#	core/src/main/java/com/netease/arctic/mixed/BasicMixedIcebergCatalog.java
@HuangFru HuangFru changed the title [AMORO-2296] Add cache for loading unkeyed tables in Trino [AMORO-2296] Add cache for loading tables in core and trino Nov 16, 2023
@shidayang
Copy link
Contributor

LGTM

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baiyangtx baiyangtx merged commit 244c1cf into apache:master Nov 23, 2023
5 of 7 checks passed
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
)

* add cache for loading tables

* fix checkstyle

* implement caching catalog in BasicMixedIcebergCatalog

* extract namespace catalog

* extract namespace catalog

* resolve conflict

* resolve conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:core Core module module:mixed-trino trino module for Mixed Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Add cache for loading table when get table meta in unkeyed table
4 participants