-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2290] Add planning
optimizing status for tables
#2323
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2323 +/- ##
============================================
- Coverage 52.67% 52.64% -0.03%
- Complexity 4216 4218 +2
============================================
Files 511 511
Lines 29342 29356 +14
Branches 2853 2853
============================================
- Hits 15455 15454 -1
- Misses 12635 12654 +19
+ Partials 1252 1248 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for your contribution!
ams/server/src/main/java/com/netease/arctic/server/table/TableRuntime.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/optimizing/OptimizingQueue.java
Outdated
Show resolved
Hide resolved
huyuanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
5ec6937
to
1c8974e
Compare
1c8974e
to
773da75
Compare
773da75
to
1f2496f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add planning optimizing status for tables * fix comment * fixed * spotless * static * merge and fix * merge and fix --------- Co-authored-by: huyuanfeng <huyuanfeng@huya.com> Co-authored-by: baiyangtx <xiangnebula@163.com>
Why are the changes needed?
Close #2290.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation