Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2290] Add planning optimizing status for tables #2323

Merged
merged 10 commits into from
Nov 23, 2023

Conversation

huyuanfeng2018
Copy link
Contributor

Why are the changes needed?

Close #2290.

Brief change log

  • Add planning optimizing status for tables
image

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (6679e01) 52.67% compared to head (7985602) 52.64%.

❗ Current head 7985602 differs from pull request most recent head 9dad99f. Consider uploading reports for the commit 9dad99f to get more accurate results

Files Patch % Lines
.../com/netease/arctic/server/table/TableRuntime.java 47.36% 9 Missing and 1 partial ⚠️
...ease/arctic/server/optimizing/OptimizingQueue.java 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2323      +/-   ##
============================================
- Coverage     52.67%   52.64%   -0.03%     
- Complexity     4216     4218       +2     
============================================
  Files           511      511              
  Lines         29342    29356      +14     
  Branches       2853     2853              
============================================
- Hits          15455    15454       -1     
- Misses        12635    12654      +19     
+ Partials       1252     1248       -4     
Flag Coverage Δ
core 52.96% <51.72%> (-0.02%) ⬇️
trino 50.93% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huyuanfeng2018 huyuanfeng2018 requested review from baiyangtx, majin1102, wangtaohz and zhoujinsong and removed request for baiyangtx and majin1102 November 20, 2023 02:10
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for your contribution!

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ baiyangtx
❌ huyuanfeng


huyuanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@HuangFru HuangFru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the entire optimizing process and the restart of AMS in the planning status locally, and there were no problems.
截屏2023-11-23 15 29 58

Copy link
Contributor

@majin1102 majin1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majin1102 majin1102 merged commit 8b59ba2 into apache:master Nov 23, 2023
4 of 5 checks passed
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
* Add planning optimizing status for tables

* fix comment

* fixed

* spotless

* static

* merge and fix

* merge and fix

---------

Co-authored-by: huyuanfeng <huyuanfeng@huya.com>
Co-authored-by: baiyangtx <xiangnebula@163.com>
@zhoujinsong zhoujinsong mentioned this pull request Jun 25, 2024
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Add planning optimizing status for tables
6 participants