Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-2373] resolve the catalog problem when querying base on kyuubi+flink #2395

Merged
merged 11 commits into from
Dec 21, 2023
Merged

[AMORO-2373] resolve the catalog problem when querying base on kyuubi+flink #2395

merged 11 commits into from
Dec 21, 2023

Conversation

liuzyou6
Copy link
Contributor

@liuzyou6 liuzyou6 commented Dec 1, 2023

when querying used catalog, the syntax is different between FLink and Spark. #2373

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ liuzyou6
✅ zhoujinsong
❌ liuzy523

liuzy523 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Dec 1, 2023
@shidayang
Copy link
Contributor

LGTM

@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5f35ce2) 52.95% compared to head (9183c95) 52.95%.

Files Patch % Lines
...e/arctic/server/terminal/kyuubi/KyuubiSession.java 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2395   +/-   ##
=========================================
  Coverage     52.95%   52.95%           
- Complexity     4415     4418    +3     
=========================================
  Files           534      534           
  Lines         30537    30542    +5     
  Branches       2989     2989           
=========================================
+ Hits          16171    16175    +4     
+ Misses        13075    13074    -1     
- Partials       1291     1293    +2
Flag Coverage Δ
core 53.32% <0.00%> (+<0.01%) ⬆️
trino 50.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuzyou6 liuzyou6 changed the title resolve the catalog problem when querying base on kyuubi+flink [AMORO-2373] resolve the catalog problem when querying base on kyuubi+flink Dec 1, 2023
@wangtaohz
Copy link
Contributor

Thank you for your contribution, the title should be [AMORO-2373]xxx. 😊

wangtaohz
wangtaohz approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

baiyangtx
baiyangtx approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhoujinsong
zhoujinsong approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuzyou6 Thanks a lot for contribution!

I left some small suggestion, please task a look.

ams/server/src/main/java/com/netease/arctic/server/terminal/kyuubi/KyuubiSession.java Outdated Show resolved Hide resolved
@zhoujinsong
Copy link
Contributor

@liuzyou6 Thanks a lot for your contribution!

You may need to sign NetEase's CLA before you start to contribute to Amoro, you can conveniently complete the signing via the link: https://cla-assistant.io/NetEase/amoro

@shidayang shidayang merged commit a6f1425 into apache:master Dec 21, 2023
5 of 7 checks passed
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
@liuzyou6 @ShawHee
[AMORO-2373] resolve the catalog problem when querying base on kyuubi…
62b4e74 
…+flink (apache#2395)
zhoujinsong pushed a commit that referenced this pull request Feb 2, 2024
@liuzyou6 @zhoujinsong
[AMORO-2373] resolve the catalog problem when querying base on kyuubi…
03de5ee 
…+flink (#2395)

(cherry picked from commit a6f1425)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangtaohz wangtaohz wangtaohz approved these changes

@shidayang shidayang shidayang approved these changes

@baiyangtx baiyangtx baiyangtx approved these changes

@zhoujinsong zhoujinsong zhoujinsong approved these changes

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzyou6 @CLAassistant @shidayang @wangtaohz @zhoujinsong @baiyangtx