Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2638] fix refresh-external-catalogs cannot be completed when exist database listTable fails #2639

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

huyuanfeng2018
Copy link
Contributor

Why are the changes needed?

Close #2638.

Brief change log

  • Catch exceptions generated by listTables

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


huyuanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the module:ams-server Ams server module label Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 34.84%. Comparing base (71bb159) to head (26c25f5).

Files Patch % Lines
...tease/arctic/server/table/DefaultTableService.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2639   +/-   ##
=========================================
  Coverage     34.83%   34.84%           
- Complexity     4506     4509    +3     
=========================================
  Files           605      605           
  Lines         50616    50619    +3     
  Branches       6655     6655           
=========================================
+ Hits          17631    17636    +5     
- Misses        31533    31534    +1     
+ Partials       1452     1449    -3     
Flag Coverage Δ
core 33.18% <40.00%> (ø)
trino 50.95% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baiyangtx baiyangtx merged commit c1c615f into apache:master Mar 15, 2024
6 of 7 checks passed
@huyuanfeng2018 huyuanfeng2018 deleted the AMORO-2638 branch March 15, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
3 participants