Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-2842] Support list all paimon branch #3093

Merged
merged 6 commits into from
Nov 1, 2024
Merged

[AMORO-2842] Support list all paimon branch #3093

merged 6 commits into from
Nov 1, 2024

Conversation

huyuanfeng2018
Copy link
Contributor

Why are the changes needed?

Close #2842.

Brief change log

  • Support list all paimon branch

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@huyuanfeng2018 huyuanfeng2018 marked this pull request as draft August 12, 2024 09:03
@github-actions github-actions bot added the module:ams-server Ams server module label Aug 12, 2024
@huyuanfeng2018
Copy link
Contributor Author

Paimon's branch is not yet perfect, and we will continue to push this feature after it is perfected.

@github-actions GitHub Actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 12, 2024
@github-actions GitHub Actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Sep 19, 2024
@github-actions github-actions bot added module:ams-dashboard Ams dashboard module module:common and removed stale labels Sep 20, 2024
@huyuanfeng2018 huyuanfeng2018 marked this pull request as ready for review September 24, 2024 08:04
@huyuanfeng2018
Copy link
Contributor Author

huyuanfeng2018 commented Sep 24, 2024 •
edited
Loading

image Works fine in my local

@czy006 czy006 self-requested a review October 14, 2024 11:30
czy006
czy006 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czy006 czy006 merged commit bbb4062 into apache:master Nov 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czy006 czy006 czy006 approved these changes

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module module:common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Support list all paimon branch
2 participants
@huyuanfeng2018 @czy006