[AMORO-3111]Avoid optimization state blocking in planning #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfyu
changed the title
zhoujinsong
reviewed
Sep 11, 2024
There was a problem hiding this comment.
@rfyu Thanks for the contribution, I left some comments, PTAL.
| } catch (Exception e) { | ||
| OptimizingStatus originalStatus = optimizingStatus; | ||
| updateOptimizingStatus(OptimizingStatus.PENDING); | ||
| LOG.error( |
There was a problem hiding this comment.
Warn logging level may be proper here.
| @@ -299,7 +299,7 @@ public class AmoroManagementConf { | |||
| public static final ConfigOption<Long> DB_CONNECT_MAX_WAIT_MILLIS = | |||
| ConfigOptions.key("database.connection-pool-max-wait-millis") | |||
| .longType() | |||
| .defaultValue(1000L) | |||
| .defaultValue(-1L) | |||
There was a problem hiding this comment.
We may need to roll back the change here.
zhoujinsong
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Avoid optimization state blocking in planning * modify the optimizing status in memory * fix conflict and rollback configuration (cherry picked from commit 292111f) Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
XBaith
pushed a commit
to XBaith/amoro
that referenced
this pull request
Dec 10, 2024
* Avoid optimization state blocking in planning * modify the optimizing status in memory * fix conflict and rollback configuration (cherry picked from commit 292111f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3111.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation